hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Damien Carol (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-7374) SHOW COMPACTIONS fail on trunk
Date Thu, 10 Jul 2014 08:06:06 GMT

    [ https://issues.apache.org/jira/browse/HIVE-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14057252#comment-14057252
] 

Damien Carol commented on HIVE-7374:
------------------------------------

I looked into the test failures. Here my conclusions :

Many tests rely on the fact that the metastore returns an object {{ShowCompactResponse}} with
{{compacts}} property at {{null}}
But this patch changed that because this throws errors in Thrift (this property is required).
I made this change in unit tests :
{code}
ShowCompactResponse rsp = txnHandler.showCompact(new ShowCompactRequest());
Assert.assertEquals(0, rsp.getCompactsSize());
{code}
Instead of :
{code}
ShowCompactResponse rsp = txnHandler.showCompact(new ShowCompactRequest());
Assert.assertNull(rsp.getCompacts());
{code}
This fix these tests :
* org.apache.hadoop.hive.metastore.txn.TestCompactionTxnHandler.testMarkCleaned
* org.apache.hadoop.hive.ql.txn.compactor.TestCleaner.cleanupAfterMajorPartitionCompaction
* org.apache.hadoop.hive.ql.txn.compactor.TestCleaner.cleanupAfterMajorPartitionCompactionNoBase
* org.apache.hadoop.hive.ql.txn.compactor.TestCleaner.cleanupAfterMajorTableCompaction
* org.apache.hadoop.hive.ql.txn.compactor.TestCleaner.cleanupAfterMinorPartitionCompaction
* org.apache.hadoop.hive.ql.txn.compactor.TestCleaner.cleanupAfterMinorTableCompaction
* org.apache.hadoop.hive.ql.txn.compactor.TestInitiator.noCompactOnManyDifferentPartitionAborts
* org.apache.hadoop.hive.ql.txn.compactor.TestInitiator.noCompactTableDeltaPctNotHighEnough
* org.apache.hadoop.hive.ql.txn.compactor.TestInitiator.noCompactTableNotEnoughDeltas
* org.apache.hadoop.hive.ql.txn.compactor.TestInitiator.noCompactWhenNoCompactSet

This test IS NOT due to this patch.
* org.apache.hive.jdbc.miniHS2.TestHiveServer2.testConnection

> SHOW COMPACTIONS fail on trunk
> ------------------------------
>
>                 Key: HIVE-7374
>                 URL: https://issues.apache.org/jira/browse/HIVE-7374
>             Project: Hive
>          Issue Type: Bug
>          Components: CLI, Metastore
>    Affects Versions: 0.14.0
>            Reporter: Damien Carol
>            Assignee: Damien Carol
>              Labels: cli, compaction, metastore
>         Attachments: HIVE-7374.1.patch
>
>
> In CLI in trunk after doing this :
> {{show compactions;}}
> Return error :
> {noformat}
> FAILED: Execution Error, return code 1 from org.apache.hadoop.hive.ql.exec.DDLTask. org.apache.thrift.transport.TTransportException
> {noformat}
> In metatore :
> {noformat}
> 2014-07-09 17:54:10,537 ERROR [pool-3-thread-20]: server.TThreadPoolServer (TThreadPoolServer.java:run(213))
- Thrift error occurred during processing of message.
> org.apache.thrift.protocol.TProtocolException: Required field 'compacts' is unset! Struct:ShowCompactResponse(compacts:null)
>         at org.apache.hadoop.hive.metastore.api.ShowCompactResponse.validate(ShowCompactResponse.java:310)
>         at org.apache.hadoop.hive.metastore.api.ThriftHiveMetastore$show_compact_result.validate(ThriftHiveMetastore.java)
>         at org.apache.hadoop.hive.metastore.api.ThriftHiveMetastore$show_compact_result$show_compact_resultStandardScheme.write(ThriftHiveMetastore.java)
>         at org.apache.hadoop.hive.metastore.api.ThriftHiveMetastore$show_compact_result$show_compact_resultStandardScheme.write(ThriftHiveMetastore.java)
>         at org.apache.hadoop.hive.metastore.api.ThriftHiveMetastore$show_compact_result.write(ThriftHiveMetastore.java)
>         at org.apache.thrift.ProcessFunction.process(ProcessFunction.java:53)
>         at org.apache.hadoop.hive.metastore.TUGIBasedProcessor.process(TUGIBasedProcessor.java:103)
>         at org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:206)
>         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
>         at java.lang.Thread.run(Thread.java:744)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message