hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szehon Ho" <>
Subject Re: Review Request 24084: HIVE-7547 - Add ipAddress and userName to ExecHook
Date Wed, 30 Jul 2014 23:40:47 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 30, 2014, 11:40 p.m.)

Review request for hive.


Incorporating Brock and Thejas review comments.  As Thejas pointed out, turns out ipAddress
is already stored in sessionState, so using that and code becomes a lot cleaner.  

However, the ipAddress calculated in TSetIpAddressProcessor doesnt work in kerberos mode,
so fixing it so its set in all modes.

Bugs: HIVE-7547

Repository: hive-git


Passing the ipAddress and userName (already calculated in ThriftCLIService for other purposes)
through several layers down to the hooks.

Diffs (updated)

  itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/ PRE-CREATION

  itests/hive-unit/src/test/java/org/apache/hadoop/hive/hooks/ PRE-CREATION

  ql/src/java/org/apache/hadoop/hive/ql/ e512199 
  ql/src/java/org/apache/hadoop/hive/ql/hooks/ b11cb86 
  service/src/java/org/apache/hive/service/cli/ add37a1 
  service/src/java/org/apache/hive/service/cli/session/ 9785e95 
  service/src/java/org/apache/hive/service/cli/session/ 816bea4 
  service/src/java/org/apache/hive/service/cli/thrift/ 5c87bcb 



Added tests in both kerberos and non-kerberos mode.


Szehon Ho

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message