hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashish Singh" <asi...@cloudera.com>
Subject Re: Review Request 23953: HIVE-7519: Refactor QTestUtil to remove its duplication with QFileClient for qtest setup and teardown
Date Mon, 28 Jul 2014 20:34:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23953/#review48802
-----------------------------------------------------------



data/scripts/q_test_init.sql
<https://reviews.apache.org/r/23953/#comment85547>

    Even I wanted to have this, but unfortunately hive cli does not preprocess hiveconf variables.
So, at this time I do not see an easy way to achieve this. One way would be to parse each
statement and replace this variable with value obtained from hive conf. But, I do not consider
that to be a good solution. Let me know if you think otherwise.



itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java
<https://reviews.apache.org/r/23953/#comment85675>

    This is now obtained from system properties, however, I have set the default value as
what we have right now. Let me know if this is not what you were suggesting.



itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java
<https://reviews.apache.org/r/23953/#comment85674>

    Done.



itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java
<https://reviews.apache.org/r/23953/#comment85677>

    ClientSessionState tells hive from where to get its input and where to log output and
error messages. Redirecting the output and error to stdout, redirects the logs from the init
scripts to go into surefire report. Let me know if this doesn't answer your question.


- Ashish Singh


On July 25, 2014, 10:49 p.m., Ashish Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23953/
> -----------------------------------------------------------
> 
> (Updated July 25, 2014, 10:49 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-7519
>     https://issues.apache.org/jira/browse/HIVE-7519
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-7519: Refactor QTestUtil to remove its duplication with QFileClient for qtest setup
and teardown
> 
> 
> Diffs
> -----
> 
>   data/scripts/q_test_cleanup.sql 31bd7205d85916ea352f715f2fd1462efc788208 
>   data/scripts/q_test_init.sql 12afdf391132e3fdd219aaa581e1f2e210d6dee2 
>   itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 2fefa067791bd74412c0b4efb697dc0d8bb03cd7

> 
> Diff: https://reviews.apache.org/r/23953/diff/
> 
> 
> Testing
> -------
> 
> qTests.
> 
> 
> Thanks,
> 
> Ashish Singh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message