hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szehon Ho" <sze...@cloudera.com>
Subject Re: Review Request 22946: HIVE-7286: Parameterize HCatMapReduceTest for testing against all Hive storage formats.
Date Sat, 26 Jul 2014 00:43:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22946/#review48792
-----------------------------------------------------------


Thanks David, it looks much cleaner, just some questions below.


ql/pom.xml
<https://reviews.apache.org/r/22946/#comment85541>

    Why disable tests here?



serde/src/test/resources/alltypes.avsc
<https://reviews.apache.org/r/22946/#comment85540>

    Do we still need this file?


- Szehon Ho


On July 25, 2014, 9:25 p.m., David Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22946/
> -----------------------------------------------------------
> 
> (Updated July 25, 2014, 9:25 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-7286
>     https://issues.apache.org/jira/browse/HIVE-7286
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-7286: Parameterize HCatMapReduceTest for testing against all Hive storage formats.
> 
> 
> Diffs
> -----
> 
>   .gitignore d0c97d12755113817f8fd04ac03357e5ceb695af 
>   hcatalog/core/pom.xml b5e85cd867cb3376da3332f7376bca46e95eff89 
>   hcatalog/core/src/test/java/org/apache/hive/hcatalog/fileformats/TestOrcDynamicPartitioned.java
f68dbb8355cb90c5d62e8c384588c4760b266a25 
>   hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/HCatMapReduceTest.java
9ddc3a6288678dfd643eb2ad17b0e0e6ad207e9f 
>   hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatDynamicPartitioned.java
39e92081aa78ad58d04972bc9216888d85d20072 
>   hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatExternalDynamicPartitioned.java
083876542fb33834169508d2fe646a0af4db0e1e 
>   hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatExternalNonPartitioned.java
01b2ad6e8a5a3db21cf6be55210452d4da8e3d52 
>   hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatExternalPartitioned.java
e5f8d1e385339f0b4c2e5711d73533b524b01bee 
>   hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatMutableDynamicPartitioned.java
bfc6a4f918c868420868e350b8c23d3414c5a747 
>   hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatMutableNonPartitioned.java
a944023441facbae0402254764a31051d60a24f6 
>   hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatMutablePartitioned.java
73d6e802be6d0e17396fc39f6b0282eadf1146a1 
>   hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatNonPartitioned.java
d639e9966687e0d885f93afbb3b7fb6568d50edc 
>   hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatPartitioned.java
dc05f431d9a1f8dbc8362499a672c7816cc82526 
>   ql/pom.xml 0729d47f25bb23705ae819d8ece97309eaeee5b8 
>   ql/src/test/org/apache/hadoop/hive/ql/io/StorageFormats.java PRE-CREATION 
>   serde/src/test/resources/alltypes.avsc PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22946/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message