hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashish Singh" <asi...@cloudera.com>
Subject Re: Review Request 23387: HIVE-6806: Native avro support
Date Sat, 19 Jul 2014 05:01:50 GMT


> On July 17, 2014, 1:49 p.m., Tom White wrote:
> > serde/src/java/org/apache/hadoop/hive/serde2/avro/TypeInfoToSchema.java, line 229
> > <https://reviews.apache.org/r/23387/diff/8/?file=634160#file634160line229>
> >
> >     It would be simpler to make sure that NULL is included (and is the first branch
in the union) in the createAvroUnion() method, and just fall through here.
> 
> Ashish Singh wrote:
>     I do not think this will be something good or feasible without redesigning many parts
without any obvious gain. createAvroUnion() only creates a schema for union, based on union
typeinfo passed to it. If I hack it to add null to all unions, I will still need to handle
union here differently as union of unions is not possible.
> 
> Tom White wrote:
>     That's OK. What you have now is much better, although I found a small bug where the
null isn't being added to the start of the list (see other comment).

OK. Dropping this issue.


- Ashish


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23387/#review48004
-----------------------------------------------------------


On July 17, 2014, 9:10 p.m., Ashish Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23387/
> -----------------------------------------------------------
> 
> (Updated July 17, 2014, 9:10 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-6806
>     https://issues.apache.org/jira/browse/HIVE-6806
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-6806: Native avro support
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/io/AvroStorageFormatDescriptor.java PRE-CREATION

>   ql/src/java/org/apache/hadoop/hive/ql/io/IOConstants.java 1bae0a8fee04049f90b16d813ff4c96707b349c8

>   ql/src/main/resources/META-INF/services/org.apache.hadoop.hive.ql.io.StorageFormatDescriptor
a23ff115512da5fe3167835a88d582c427585b8e 
>   ql/src/test/org/apache/hadoop/hive/ql/io/TestStorageFormatDescriptor.java d53ebc65174d66bfeee25fd2891c69c78f9137ee

>   ql/src/test/queries/clientpositive/avro_compression_enabled_native.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/avro_decimal_native.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/avro_joins_native.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/avro_native.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/avro_partitioned_native.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/avro_schema_evolution_native.q PRE-CREATION 
>   ql/src/test/results/clientpositive/avro_compression_enabled_native.q.out PRE-CREATION

>   ql/src/test/results/clientpositive/avro_decimal_native.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/avro_joins_native.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/avro_native.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/avro_partitioned_native.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/avro_schema_evolution_native.q.out PRE-CREATION

>   serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java 0db12437406170686a21b6055d83156fe5d6a55f

>   serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java 1fe31e0034f8988d03a0c51a90904bb93e7cb157

>   serde/src/java/org/apache/hadoop/hive/serde2/avro/TypeInfoToSchema.java PRE-CREATION

>   serde/src/test/org/apache/hadoop/hive/serde2/avro/TestTypeInfoToSchema.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/23387/diff/
> 
> 
> Testing
> -------
> 
> Added qTests and unit tests
> 
> 
> Thanks,
> 
> Ashish Singh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message