hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brock Noland" <br...@cloudera.com>
Subject Re: Review Request 23387: HIVE-6806: Native Avro support in Hive
Date Thu, 10 Jul 2014 15:01:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23387/#review47568
-----------------------------------------------------------


I *love* this patch! Thank you so much.


serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSchemaGenerator.java
<https://reviews.apache.org/r/23387/#comment83585>

    Can we add some unit tests for this class?



serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSchemaGenerator.java
<https://reviews.apache.org/r/23387/#comment83588>

    Two thoughts:
    
    1) Char/varchar support?
    2) By defaulting to null won't any new types end up with null if this code is not updated?
I think instead we should throw an exception for unknown types.


- Brock Noland


On July 10, 2014, 4:50 a.m., Ashish Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23387/
> -----------------------------------------------------------
> 
> (Updated July 10, 2014, 4:50 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-6806
>     https://issues.apache.org/jira/browse/HIVE-6806
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-6806: Native Avro support in Hive
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 75394f3bc4f2285a7ced97ea90788d5bbff6b563

>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 6cd1f39df3d419651755c35aab7cfc06833b16a4

>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 412a046488eaea42a6416c7cbd514715d37e249f

>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g f934ac4e3b736eed1b3060fa516124c67f9a2f87

>   ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 9c001c1495b423c19f3fa710c74f1bb1e24a08f4

>   ql/src/test/queries/clientpositive/avro_compression_enabled_native.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/avro_decimal_native.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/avro_joins_native.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/avro_native.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/avro_partitioned_native.q PRE-CREATION 
>   ql/src/test/results/clientpositive/avro_compression_enabled_native.q.out PRE-CREATION

>   ql/src/test/results/clientpositive/avro_decimal_native.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/avro_joins_native.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/avro_partitioned_native.q.out PRE-CREATION 
>   serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSchemaGenerator.java PRE-CREATION

>   serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java 1fe31e0034f8988d03a0c51a90904bb93e7cb157

> 
> Diff: https://reviews.apache.org/r/23387/diff/
> 
> 
> Testing
> -------
> 
> Added qTests
> 
> 
> Thanks,
> 
> Ashish Singh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message