hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Navis Ryu" <navis....@nexr.com>
Subject Re: Review Request 23320: HiveServer2 using embedded MetaStore leaks JDOPersistanceManager
Date Thu, 10 Jul 2014 05:52:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/#review47551
-----------------------------------------------------------



metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/23320/#comment83558>

    I cannot believe that it was not static. Other threadlocals below(threadLocalTxn, threadLocalConf)
also should be static field. 
    
    And, 'final' modifiers could be applied.



service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java
<https://reviews.apache.org/r/23320/#comment83557>

    This makes the object store shared between two or more threads, which will introduce transaction
problem in it. 


- Navis Ryu


On July 7, 2014, 8:29 p.m., Vaibhav Gumashta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23320/
> -----------------------------------------------------------
> 
> (Updated July 7, 2014, 8:29 p.m.)
> 
> 
> Review request for hive, Sushanth Sowmyan and Thejas Nair.
> 
> 
> Bugs: HIVE-7353
>     https://issues.apache.org/jira/browse/HIVE-7353
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/HIVE-7353
> 
> 
> Diffs
> -----
> 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java acef599 
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java de54ca1 
> 
> Diff: https://reviews.apache.org/r/23320/diff/
> 
> 
> Testing
> -------
> 
> Manual testing using Yourkit.
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message