hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thejas Nair" <the...@hortonworks.com>
Subject Re: Review Request 23139: HIVE-7294 : sql std auth - authorize show grant statements
Date Tue, 01 Jul 2014 09:16:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23139/
-----------------------------------------------------------

(Updated July 1, 2014, 9:16 a.m.)


Review request for hive.


Changes
-------

HIVE-7294.2.patch - also authorizes 'show role grant' statements.


Bugs: HIVE-7294
    https://issues.apache.org/jira/browse/HIVE-7294


Repository: hive-git


Description
-------

See jira


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java d8d900b 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java
e4f5aac 
  ql/src/test/queries/clientnegative/authorization_insertoverwrite_nodel.q 90fe6e1 
  ql/src/test/queries/clientnegative/authorization_priv_current_role_neg.q bbf3b66 
  ql/src/test/queries/clientnegative/authorization_role_grant_otherrole.q PRE-CREATION 
  ql/src/test/queries/clientnegative/authorization_role_grant_otheruser.q PRE-CREATION 
  ql/src/test/queries/clientnegative/authorization_show_grant_otherrole.q PRE-CREATION 
  ql/src/test/queries/clientnegative/authorization_show_grant_otheruser_all.q PRE-CREATION

  ql/src/test/queries/clientnegative/authorization_show_grant_otheruser_alltabs.q PRE-CREATION

  ql/src/test/queries/clientnegative/authorization_show_grant_otheruser_wtab.q PRE-CREATION

  ql/src/test/queries/clientpositive/authorization_grant_public_role.q 8473178 
  ql/src/test/queries/clientpositive/authorization_grant_table_priv.q 02d364e 
  ql/src/test/queries/clientpositive/authorization_insert.q 5de6f50 
  ql/src/test/queries/clientpositive/authorization_revoke_table_priv.q ccda3b5 
  ql/src/test/queries/clientpositive/authorization_role_grant2.q fd6aa38 
  ql/src/test/queries/clientpositive/authorization_show_grant.q PRE-CREATION 
  ql/src/test/queries/clientpositive/authorization_view_sqlstd.q bd7bbfe 
  ql/src/test/results/clientnegative/authorization_insertoverwrite_nodel.q.out de1d230 
  ql/src/test/results/clientnegative/authorization_role_grant_otherrole.q.out PRE-CREATION

  ql/src/test/results/clientnegative/authorization_role_grant_otheruser.q.out PRE-CREATION

  ql/src/test/results/clientnegative/authorization_show_grant_otherrole.q.out PRE-CREATION

  ql/src/test/results/clientnegative/authorization_show_grant_otheruser_all.q.out PRE-CREATION

  ql/src/test/results/clientnegative/authorization_show_grant_otheruser_alltabs.q.out PRE-CREATION

  ql/src/test/results/clientnegative/authorization_show_grant_otheruser_wtab.q.out PRE-CREATION

  ql/src/test/results/clientpositive/authorization_grant_public_role.q.out a0a45f7 
  ql/src/test/results/clientpositive/authorization_grant_table_priv.q.out 9a6ec17 
  ql/src/test/results/clientpositive/authorization_insert.q.out f94d9a9 
  ql/src/test/results/clientpositive/authorization_role_grant2.q.out 2e94af3 
  ql/src/test/results/clientpositive/authorization_show_grant.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/authorization_view_sqlstd.q.out 50c0247 

Diff: https://reviews.apache.org/r/23139/diff/


Testing
-------

test cases included.


Thanks,

Thejas Nair


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message