Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9990311381 for ; Mon, 16 Jun 2014 18:44:03 +0000 (UTC) Received: (qmail 1386 invoked by uid 500); 16 Jun 2014 18:44:03 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 1325 invoked by uid 500); 16 Jun 2014 18:44:03 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 1301 invoked by uid 500); 16 Jun 2014 18:44:02 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 1298 invoked by uid 99); 16 Jun 2014 18:44:02 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Jun 2014 18:44:02 +0000 Date: Mon, 16 Jun 2014 18:44:02 +0000 (UTC) From: "David Chen (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-7230) Add Eclipse formatter file for Hive coding conventions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-7230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14032759#comment-14032759 ] David Chen commented on HIVE-7230: ---------------------------------- I see. Are the rules in the formatter file at https://google-styleguide.googlecode.com/svn/trunk/eclipse-java-google-style.xml the same as the ones for the Hive coding convention? If that is the case, it does not appear that there was a patch submitted that adds that to the root pom file in any of the duplicated tickets. Would it be fine if I submit a patch that adds it to the pom file? > Add Eclipse formatter file for Hive coding conventions > ------------------------------------------------------ > > Key: HIVE-7230 > URL: https://issues.apache.org/jira/browse/HIVE-7230 > Project: Hive > Issue Type: Improvement > Reporter: David Chen > Assignee: David Chen > Attachments: HIVE-7230.1.patch > > > Eclipse's formatter is a convenient way to clean up formatting for Java code. Currently, there is no Eclipse formatter file checked into Hive's codebase. -- This message was sent by Atlassian JIRA (v6.2#6252)