Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Tue, 17 Jun 2014 18:39:07 +0000 (UTC)
From: "Alan Gates (JIRA)" <jira@apache.org>
To: hive-dev@hadoop.apache.org
Message-ID: <JIRA.12720915.1402594359472.148189.1403030347340@arcas>
In-Reply-To: <JIRA.12720915.1402594359472@arcas>
References: <JIRA.12720915.1402594359472@arcas>
Subject: [jira] [Commented] (HIVE-7225) Unclosed Statement's in TxnHandler
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HIVE-7225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14034192#comment-14034192 ] 

Alan Gates commented on HIVE-7225:
----------------------------------

No.  We aren't leaving these connections open for a long time.  We're closing them quite quickly at the end of each Thrift RPC.  If we were leaving them open for a long time then I would agree that it was important to close the statements.

> Unclosed Statement's in TxnHandler
> ----------------------------------
>
>                 Key: HIVE-7225
>                 URL: https://issues.apache.org/jira/browse/HIVE-7225
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: steve, Oh
>         Attachments: HIVE-7225.1.patch
>
>
> There're several methods in TxnHandler where Statement (local to the method) is not closed upon return.
> Here're a few examples:
> In compact():
> {code}
>         stmt.executeUpdate(s);
>         LOG.debug("Going to commit");
>         dbConn.commit();
> {code}
> In showCompact():
> {code}
>       Statement stmt = dbConn.createStatement();
>       String s = "select cq_database, cq_table, cq_partition, cq_state, cq_type, cq_worker_id, " +
>           "cq_start, cq_run_as from COMPACTION_QUEUE";
>       LOG.debug("Going to execute query <" + s + ">");
>       ResultSet rs = stmt.executeQuery(s);
> {code}


--
This message was sent by Atlassian JIRA
(v6.2#6252)