Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BA1E711666 for ; Mon, 23 Jun 2014 19:44:26 +0000 (UTC) Received: (qmail 7606 invoked by uid 500); 23 Jun 2014 19:44:26 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 7541 invoked by uid 500); 23 Jun 2014 19:44:26 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 7477 invoked by uid 500); 23 Jun 2014 19:44:26 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 7460 invoked by uid 99); 23 Jun 2014 19:44:26 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Jun 2014 19:44:26 +0000 Date: Mon, 23 Jun 2014 19:44:26 +0000 (UTC) From: "David Chen (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-7094) Separate out static/dynamic partitioning code in FileRecordWriterContainer MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-7094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14041188#comment-14041188 ] David Chen commented on HIVE-7094: ---------------------------------- Thanks, Carl and Sushanth! > Separate out static/dynamic partitioning code in FileRecordWriterContainer > -------------------------------------------------------------------------- > > Key: HIVE-7094 > URL: https://issues.apache.org/jira/browse/HIVE-7094 > Project: Hive > Issue Type: Sub-task > Components: HCatalog > Reporter: David Chen > Assignee: David Chen > Fix For: 0.14.0 > > Attachments: HIVE-7094.1.patch, HIVE-7094.3.patch, HIVE-7094.4.patch, HIVE-7094.5.patch > > > There are two major places in FileRecordWriterContainer that have the {{if (dynamicPartitioning)}} condition: the constructor and write(). > This is the approach that I am taking: > # Move the DP and SP code into two subclasses: DynamicFileRecordWriterContainer and StaticFileRecordWriterContainer. > # Make FileRecordWriterContainer an abstract class that contains the common code for both implementations. For write(), FileRecordWriterContainer will call an abstract method that will provide the local RecordWriter, ObjectInspector, SerDe, and OutputJobInfo. -- This message was sent by Atlassian JIRA (v6.2#6252)