Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 93C9911821 for ; Thu, 19 Jun 2014 20:33:25 +0000 (UTC) Received: (qmail 88634 invoked by uid 500); 19 Jun 2014 20:33:25 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 88588 invoked by uid 500); 19 Jun 2014 20:33:25 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 88563 invoked by uid 99); 19 Jun 2014 20:33:24 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Jun 2014 20:33:24 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7014D1DB146; Thu, 19 Jun 2014 20:33:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2587519493618601015==" MIME-Version: 1.0 Subject: Re: Review Request 22770: Allow partial partition spec in analyze command From: "Ashutosh Chauhan" To: "Szehon Ho" , "Ashutosh Chauhan" , "hive" Date: Thu, 19 Jun 2014 20:33:13 -0000 Message-ID: <20140619203313.6312.69051@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ashutosh Chauhan" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/22770/ X-Sender: "Ashutosh Chauhan" References: <20140619035115.6311.27713@reviews.apache.org> In-Reply-To: <20140619035115.6311.27713@reviews.apache.org> Reply-To: "Ashutosh Chauhan" X-ReviewRequest-Repository: hive-git --===============2587519493618601015== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On June 19, 2014, 3:51 a.m., Szehon Ho wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsTask.java, line 73 > > > > > > Looks like no longer used. will get rid of it. > On June 19, 2014, 3:51 a.m., Szehon Ho wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsTask.java, line 422 > > > > > > We can remove 'totalRows' variable as well. yup. will remove > On June 19, 2014, 3:51 a.m., Szehon Ho wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsTask.java, line 425 > > > > > > Do we need to cleanup the fetch operator at some point? Yeah, will do. > On June 19, 2014, 3:51 a.m., Szehon Ho wrote: > > ql/src/java/org/apache/hadoop/hive/ql/plan/ColumnStatsDesc.java, line 65 > > > > > > Same question, cant we still display partial partition spec? not sure, if its any useful in explain, but will see if I can add it back. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22770/#review46179 ----------------------------------------------------------- On June 19, 2014, 2:35 a.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22770/ > ----------------------------------------------------------- > > (Updated June 19, 2014, 2:35 a.m.) > > > Review request for hive. > > > Bugs: HIVE-7255 > https://issues.apache.org/jira/browse/HIVE-7255 > > > Repository: hive-git > > > Description > ------- > > So that stats collection can happen for multiple partitions through one statement. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 8ae1c73 > ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsTask.java 47a6871 > ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 1270520 > ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java a4ba4bd > ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java b75f78c > ql/src/java/org/apache/hadoop/hive/ql/plan/ColumnStatsDesc.java 86e6877 > ql/src/test/queries/clientnegative/columnstats_partlvl_dp.q b4887c4 > ql/src/test/queries/clientnegative/columnstats_partlvl_incorrect_num_keys.q 2f8e927 > ql/src/test/queries/clientpositive/columnstats_partlvl_dp.q PRE-CREATION > ql/src/test/queries/clientpositive/columnstats_partlvl_incorrect_num_keys.q PRE-CREATION > ql/src/test/results/clientnegative/columnstats_partlvl_invalid_values.q.out d48d8cb > ql/src/test/results/clientpositive/columnstats_partlvl.q.out a4c4677 > ql/src/test/results/clientpositive/columnstats_partlvl_dp.q.out PRE-CREATION > ql/src/test/results/clientpositive/columnstats_partlvl_incorrect_num_keys.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/22770/diff/ > > > Testing > ------- > > Moved -ve tests to +ve. > > > Thanks, > > Ashutosh Chauhan > > --===============2587519493618601015==--