Return-Path: 
 <dev-return-91137-apmail-hive-dev-archive=hive.apache.org@hive.apache.org>
X-Original-To: apmail-hive-dev-archive@www.apache.org
Delivered-To: apmail-hive-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 393011137D
	for <apmail-hive-dev-archive@www.apache.org>;
 Tue, 17 Jun 2014 01:49:18 +0000 (UTC)
Received: (qmail 74387 invoked by uid 500); 17 Jun 2014 01:49:17 -0000
Delivered-To: apmail-hive-dev-archive@hive.apache.org
Received: (qmail 74316 invoked by uid 500); 17 Jun 2014 01:49:17 -0000
Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@hive.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@hive.apache.org>
List-Post: <mailto:dev@hive.apache.org>
List-Id: <dev.hive.apache.org>
Reply-To: dev@hive.apache.org
Delivered-To: mailing list dev@hive.apache.org
Received: (qmail 74302 invoked by uid 99); 17 Jun 2014 01:49:17 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Jun 2014 01:49:17 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id AECC01D9FFE;
	Tue, 17 Jun 2014 01:49:07 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============4212719774992877190=="
MIME-Version: 1.0
Subject: Re: Review Request 19984: Beeline should accept -i option to
 Initializing a
 SQL file
From: "Navis Ryu" <navis.ryu@nexr.com>
To: "Navis Ryu" <navis.ryu@nexr.com>, "Xuefu Zhang" <xzhang@cloudera.com>,
 "hive" <dev@hive.apache.org>, "Thejas Nair" <thejas@hortonworks.com>
Date: Tue, 17 Jun 2014 01:49:07 -0000
Message-ID: <20140617014907.6312.20422@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "Navis Ryu" <noreply@reviews.apache.org>
X-ReviewGroup: hive
X-ReviewRequest-URL: https://reviews.apache.org/r/19984/
X-Sender: "Navis Ryu" <noreply@reviews.apache.org>
References: <20140507041018.28779.26130@reviews.apache.org>
In-Reply-To: <20140507041018.28779.26130@reviews.apache.org>
Reply-To: "Navis Ryu" <navis.ryu@nexr.com>
X-ReviewRequest-Repository: hive-git

--===============4212719774992877190==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19984/
-----------------------------------------------------------

(Updated June 17, 2014, 1:49 a.m.)


Review request for hive.


Changes
-------

Addressed comments


Bugs: HIVE-6561
    https://issues.apache.org/jira/browse/HIVE-6561


Repository: hive-git


Description
-------

Hive CLI has -i option. From Hive CLI help:
{code}
...
 -i <filename>                    Initialization SQL file
...
{code}

However, Beeline has no such option:
{code}
xzhang@xzlt:~/apa/hive3$ ./packaging/target/apache-hive-0.14.0-SNAPSHOT-bin/apache-hive-0.14.0-SNAPSHOT-bin/bin/beeline -u jdbc:hive2:// -i hive.rc
...
Connected to: Apache Hive (version 0.14.0-SNAPSHOT)
Driver: Hive JDBC (version 0.14.0-SNAPSHOT)
Transaction isolation: TRANSACTION_REPEATABLE_READ
-i (No such file or directory)
Property "url" is required
Beeline version 0.14.0-SNAPSHOT by Apache Hive
...
{code}


Diffs (updated)
-----

  beeline/src/java/org/apache/hive/beeline/BeeLine.java dcdd6f2 
  beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 44cabdf 
  beeline/src/java/org/apache/hive/beeline/Commands.java 94f74d2 
  beeline/src/main/resources/BeeLine.properties 697c29a 
  itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java 4d15e3c 

Diff: https://reviews.apache.org/r/19984/diff/


Testing
-------


Thanks,

Navis Ryu


--===============4212719774992877190==--