Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 95FAB119C8 for ; Thu, 12 Jun 2014 14:19:50 +0000 (UTC) Received: (qmail 60338 invoked by uid 500); 12 Jun 2014 14:19:50 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 60271 invoked by uid 500); 12 Jun 2014 14:19:50 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 60258 invoked by uid 99); 12 Jun 2014 14:19:50 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Jun 2014 14:19:50 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A10D81D9EA8; Thu, 12 Jun 2014 14:19:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6426299800698738398==" MIME-Version: 1.0 Subject: Re: Review Request 22513: HIVE-6928 : Beeline should not chop off "describe extended" results by default From: "Xuefu Zhang" To: "Chinna Lalam" , "Xuefu Zhang" , "hive" Date: Thu, 12 Jun 2014 14:19:40 -0000 Message-ID: <20140612141940.22323.6585@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Xuefu Zhang" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/22513/ X-Sender: "Xuefu Zhang" References: <20140612141143.22324.59927@reviews.apache.org> In-Reply-To: <20140612141143.22324.59927@reviews.apache.org> Reply-To: "Xuefu Zhang" X-ReviewRequest-Repository: hive --===============6426299800698738398== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22513/#review45495 ----------------------------------------------------------- trunk/beeline/src/java/org/apache/hive/beeline/BeeLine.java Per Hive coding style, please strip of all trailing spaces (shown in red). - Xuefu Zhang On June 12, 2014, 2:11 p.m., Chinna Lalam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22513/ > ----------------------------------------------------------- > > (Updated June 12, 2014, 2:11 p.m.) > > > Review request for hive. > > > Repository: hive > > > Description > ------- > > The length of the row have more characters, showing the output in table format wont be looking good. When ever the row length is bigger than width, present that in vertical format (decide this in run time). > > > Diffs > ----- > > trunk/beeline/src/java/org/apache/hive/beeline/BeeLine.java 1597407 > trunk/beeline/src/java/org/apache/hive/beeline/BufferedRows.java 1597407 > trunk/beeline/src/java/org/apache/hive/beeline/IncrementalRows.java 1597407 > trunk/beeline/src/java/org/apache/hive/beeline/Rows.java 1597407 > > Diff: https://reviews.apache.org/r/22513/diff/ > > > Testing > ------- > > All unit tests are pass. > > > Thanks, > > Chinna Lalam > > --===============6426299800698738398==--