Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AABCF11CFA for ; Mon, 2 Jun 2014 18:35:11 +0000 (UTC) Received: (qmail 28354 invoked by uid 500); 2 Jun 2014 18:35:11 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 28284 invoked by uid 500); 2 Jun 2014 18:35:11 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 28268 invoked by uid 99); 2 Jun 2014 18:35:11 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Jun 2014 18:35:11 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id ACB461D9987; Mon, 2 Jun 2014 18:35:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1698328882123551417==" MIME-Version: 1.0 Subject: Review Request 22152: HIVE-7143: Add Streaming support in Windowing mode for more UDAFs (min/max, lead/lag, fval/lval) From: "Harish Butani" To: "Ashutosh Chauhan" Cc: "Harish Butani" , "hive" Date: Mon, 02 Jun 2014 18:35:02 -0000 Message-ID: <20140602183502.12450.817@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Harish Butani" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/22152/ X-Sender: "Harish Butani" Reply-To: "Harish Butani" X-ReviewRequest-Repository: hive-git --===============1698328882123551417== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22152/ ----------------------------------------------------------- Review request for hive and Ashutosh Chauhan. Bugs: HIVE-7143 https://issues.apache.org/jira/browse/HIVE-7143 Repository: hive-git Description ------- Provided implementations for Streaming for the above fns. Min/Max based on Alg by Daniel Lemire: http://www.archipel.uqam.ca/309/1/webmaximinalgo.pdf Diffs ----- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFAverage.java ab3e0bf ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFLag.java d265acc ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFLead.java d7c18e5 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFLeadLag.java 295cd2e ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFMax.java d6e9db4 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFMin.java 3dc9900 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFRank.java 775d874 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFStreamingEnhancer.java f899ae0 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFStreamingEvaluator.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java 2b82550 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/ISupportStreamingModeForWindowing.java cf2035c ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/WindowingTableFunction.java 0a67fea ql/src/test/org/apache/hadoop/hive/ql/udaf/TestStreamingMax.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/udaf/TestStreamingMin.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/udaf/TestStreamingSum.java ef6a4b5 Diff: https://reviews.apache.org/r/22152/diff/ Testing ------- existing tests; added new tests for min/max Thanks, Harish Butani --===============1698328882123551417==--