hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szehon Ho (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-7254) Enhance Ptest framework config to auto-pick up list of MiniXXXDriver's test
Date Thu, 19 Jun 2014 23:20:24 GMT

    [ https://issues.apache.org/jira/browse/HIVE-7254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038086#comment-14038086
] 

Szehon Ho commented on HIVE-7254:
---------------------------------

Thanks, property file would work fine for Ptest framework.  The refactoring of normal build
process can be done as a first change.  The PTest framework today generates cmds like "mvn
test -Dtest=TestMiniTezCliDriver -Dqfile=$batch1" using its own property file, and will continue
to work.

The actual Ptest framework class is checked into the hive repo at:  [TestParser.java|https://github.com/apache/hive/blob/trunk/testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestParser.java].
 It runs against the Ptest conf file "trunk-mr2.properties" (attached).  As a second step,
we can replace the hard-coded test names there with references to the new property file, and
have TestParser read those.

I can take a look at this, but if anyone is interested, build instructions for Ptest framework
are at : [README|https://github.com/apache/hive/blob/trunk/testutils/ptest2/README.md].  In
development, I usually run TestParser locally against the file to verify the generated-batches,
for example see [TestTestParser.java|https://github.com/apache/hive/blob/trunk/testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestTestParser.java].



> Enhance Ptest framework config to auto-pick up list of MiniXXXDriver's test
> ---------------------------------------------------------------------------
>
>                 Key: HIVE-7254
>                 URL: https://issues.apache.org/jira/browse/HIVE-7254
>             Project: Hive
>          Issue Type: Test
>          Components: Testing Infrastructure
>            Reporter: Szehon Ho
>            Assignee: Szehon Ho
>         Attachments: trunk-mr2.properties
>
>
> Today, the Hive PTest infrastructure has a test-driver configuration called "directory",
so it will run all the qfiles under that directory for that driver.  For example, CLIDriver
is configured with directory "ql/src/test/queries/clientpositive"
> However the configuration for the miniXXXDrivers (miniMRDriver, miniMRDriverNegative,
miniTezDriver) run only a select number of tests under "directory".  So we have to use the
"include" configuration to hard-code a list of tests for it to run.  This is duplicating the
list of each miniDriver's tests already in the /itests/qtest pom file, and can get out of
date.
> It would be nice if both got their information the same way.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message