hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuefu Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-7229) String is compared using equal in HiveMetaStore#HMSHandler#init()
Date Tue, 24 Jun 2014 14:38:24 GMT

    [ https://issues.apache.org/jira/browse/HIVE-7229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14042179#comment-14042179
] 

Xuefu Zhang commented on HIVE-7229:
-----------------------------------

How did you generated your patch? It seems that the precommit test doesn't like it. An easy
way is to do this:

git diff --no-prefix > HIVE-7229.patch

> String is compared using equal in HiveMetaStore#HMSHandler#init()
> -----------------------------------------------------------------
>
>                 Key: HIVE-7229
>                 URL: https://issues.apache.org/jira/browse/HIVE-7229
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>         Attachments: HIVE-7229.1.patch, HIVE-7229.patch
>
>
> Around line 423:
> {code}
>       if (partitionValidationRegex != null && partitionValidationRegex != "")
{
>         partitionValidationPattern = Pattern.compile(partitionValidationRegex);
> {code}
> partitionValidationRegex.isEmpty() can be used instead.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message