hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-7228) StreamPrinter should be joined to calling thread
Date Sun, 15 Jun 2014 07:53:02 GMT

    [ https://issues.apache.org/jira/browse/HIVE-7228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14031801#comment-14031801
] 

Hive QA commented on HIVE-7228:
-------------------------------



{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12650319/HIVE-7228.patch

{color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 5536 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_join30
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_parquet_columnar
org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_root_dir_external_table
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_ctas
org.apache.hive.hcatalog.pig.TestHCatLoader.testReadDataPrimitiveTypes
{noformat}

Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/469/testReport
Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/469/console
Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-Build-469/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 5 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12650319

> StreamPrinter should be joined to calling thread 
> -------------------------------------------------
>
>                 Key: HIVE-7228
>                 URL: https://issues.apache.org/jira/browse/HIVE-7228
>             Project: Hive
>          Issue Type: Bug
>          Components: CLI
>    Affects Versions: 0.13.0
>            Reporter: Pankit Thapar
>            Assignee: Pankit Thapar
>            Priority: Minor
>         Attachments: HIVE-7228.patch
>
>
> ISSUE:
> StreamPrinter class is used for connecting an input stream (connected to output) of a
process with the output stream of a Session (CliSessionState/SessionState class)
> It acts as a pipe between the two and transfers data from input stream to the output
stream. THE TRANSFER OPERATION RUNS IN A SEPARATE THREAD. 
> From some of the current usages of this class, I noticed that the calling threads do
not wait for the transfer operation to be completed. That is, the calling thread does not
join the SteamPrinter threads.
> The calling thread would move forward thinking that the respective output stream already
has the data needed. But, it is not always the right assumption since, it might happen that
> the StreamPrinter thread did not finish execution by the time it was expected by the
calling thread.
> FIX:
> To ensure that calling thread waits for the StreamPrinter threads to complete, StreamPrinter
threads are joined to calling thread.
> Please note , without the fix, TestCliDriverMethods#testRun failed sometimes (like 1
in 30 times). This test would not fail with this fix.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message