hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-7225) Unclosed Statement's in TxnHandler
Date Wed, 18 Jun 2014 21:10:25 GMT

    [ https://issues.apache.org/jira/browse/HIVE-7225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036388#comment-14036388
] 

Ted Yu commented on HIVE-7225:
------------------------------

bq. whether the default is to close the open statements
As far as I can tell from the source code, default value for closeOpenStatements is false.
This is understandable: tracking open statements would consume more resources. For well designed
/ implemented client, this shouldn't be necessary.

bq. make sure we close the statements
Do you have time to take a look at Steve's patch ?

Thanks

> Unclosed Statement's in TxnHandler
> ----------------------------------
>
>                 Key: HIVE-7225
>                 URL: https://issues.apache.org/jira/browse/HIVE-7225
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: steve, Oh
>         Attachments: HIVE-7225.1.patch
>
>
> There're several methods in TxnHandler where Statement (local to the method) is not closed
upon return.
> Here're a few examples:
> In compact():
> {code}
>         stmt.executeUpdate(s);
>         LOG.debug("Going to commit");
>         dbConn.commit();
> {code}
> In showCompact():
> {code}
>       Statement stmt = dbConn.createStatement();
>       String s = "select cq_database, cq_table, cq_partition, cq_state, cq_type, cq_worker_id,
" +
>           "cq_start, cq_run_as from COMPACTION_QUEUE";
>       LOG.debug("Going to execute query <" + s + ">");
>       ResultSet rs = stmt.executeQuery(s);
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message