hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Jarcec Cecho (JIRA)" <>
Subject [jira] [Commented] (HIVE-7174) Do not accept string as scale and precision when reading Avro schema
Date Fri, 06 Jun 2014 03:52:01 GMT


Jarek Jarcec Cecho commented on HIVE-7174:

I've noticed that file {{dev.avro}} has been created with incorrect schema, so I've attached
fixed version.  Attached file should replace the one in {{data/files/dec.avro}}.

> Do not accept string as scale and precision when reading Avro schema
> --------------------------------------------------------------------
>                 Key: HIVE-7174
>                 URL:
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 0.14.0
>         Attachments: HIVE-7174.patch, dec.avro
> I've noticed that the current AvroSerde will happily accept schema that uses string instead
of integer for scale and precision, e.g. fragment {{"precision":"4","scale":"1"}} from following
> {code}
> CREATE TABLE `avro_dec1`(
>   `name` string COMMENT 'from deserializer',
>   `value` decimal(4,1) COMMENT 'from deserializer')
> COMMENT 'just drop the schema right into the HQL'
>   'org.apache.hadoop.hive.serde2.avro.AvroSerDe'
>   ''
>   ''
>   'numFiles'='1',
>   'avro.schema.literal'='{\"namespace\":\"com.howdy\",\"name\":\"some_schema\",\"type\":\"record\",\"fields\":[{\"name\":\"name\",\"type\":\"string\"},{\"name\":\"value\",\"type\":{\"type\":\"bytes\",\"logicalType\":\"decimal\",\"precision\":\"4\",\"scale\":\"1\"}}]}'
> );
> {code}
> However the Decimal spec defined in AVRO-1402 requires only integer to be there and hence
is allowing only following fragment instead {{"precision":4,"scale":1}} (e.g. no double quotes
around numbers).
> As Hive can propagate this incorrect schema to new files and hence creating files with
invalid schema, I think that we should alter the behavior and insist on the correct schema.

This message was sent by Atlassian JIRA

View raw message