hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Chen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-7094) Separate out static/dynamic partitioning code in FileRecordWriterContainer
Date Wed, 18 Jun 2014 19:40:25 GMT

    [ https://issues.apache.org/jira/browse/HIVE-7094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036250#comment-14036250
] 

David Chen commented on HIVE-7094:
----------------------------------

Thanks, Sushanth. I have updated the RB with my latest patch.

> Separate out static/dynamic partitioning code in FileRecordWriterContainer
> --------------------------------------------------------------------------
>
>                 Key: HIVE-7094
>                 URL: https://issues.apache.org/jira/browse/HIVE-7094
>             Project: Hive
>          Issue Type: Sub-task
>          Components: HCatalog
>            Reporter: David Chen
>            Assignee: David Chen
>         Attachments: HIVE-7094.1.patch, HIVE-7094.3.patch, HIVE-7094.4.patch, HIVE-7094.5.patch
>
>
> There are two major places in FileRecordWriterContainer that have the {{if (dynamicPartitioning)}}
condition: the constructor and write().
> This is the approach that I am taking:
> # Move the DP and SP code into two subclasses: DynamicFileRecordWriterContainer and StaticFileRecordWriterContainer.
> # Make FileRecordWriterContainer an abstract class that contains the common code for
both implementations. For write(), FileRecordWriterContainer will call an abstract method
that will provide the local RecordWriter, ObjectInspector, SerDe, and OutputJobInfo.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message