hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sushanth Sowmyan (JIRA)" <>
Subject [jira] [Commented] (HIVE-7094) Separate out static/dynamic partitioning code in FileRecordWriterContainer
Date Wed, 18 Jun 2014 19:36:25 GMT


Sushanth Sowmyan commented on HIVE-7094:

Hi David,

I've looked at the patch, and I think you're good, but could you please update the reviewboard
link with the latest patch you've uploaded so I can quickly verify?

> Separate out static/dynamic partitioning code in FileRecordWriterContainer
> --------------------------------------------------------------------------
>                 Key: HIVE-7094
>                 URL:
>             Project: Hive
>          Issue Type: Sub-task
>          Components: HCatalog
>            Reporter: David Chen
>            Assignee: David Chen
>         Attachments: HIVE-7094.1.patch, HIVE-7094.3.patch, HIVE-7094.4.patch, HIVE-7094.5.patch
> There are two major places in FileRecordWriterContainer that have the {{if (dynamicPartitioning)}}
condition: the constructor and write().
> This is the approach that I am taking:
> # Move the DP and SP code into two subclasses: DynamicFileRecordWriterContainer and StaticFileRecordWriterContainer.
> # Make FileRecordWriterContainer an abstract class that contains the common code for
both implementations. For write(), FileRecordWriterContainer will call an abstract method
that will provide the local RecordWriter, ObjectInspector, SerDe, and OutputJobInfo.

This message was sent by Atlassian JIRA

View raw message