hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashish Singh" <asi...@cloudera.com>
Subject Re: Review Request 22772: HIVE-6637: UDF in_file() doesn't take CHAR or VARCHAR as input
Date Fri, 20 Jun 2014 21:15:46 GMT


> On June 20, 2014, 1:04 a.m., Jason Dere wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInFile.java, line 99
> > <https://reviews.apache.org/r/22772/diff/2/?file=613098#file613098line99>
> >
> >     Rather than having to compare the actual class/class name of the type, use call
PrimitiveObjectInpsector.getPrimitiveCategory() which returns an enum corresponding to the
type.  Take a look at GenericUDFPrintf, where Xuefu made similar changes to the printf() function
to support char/varchar.

Jason, good suggestion. Made required changes.


- Ashish


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22772/#review46246
-----------------------------------------------------------


On June 20, 2014, 9:15 p.m., Ashish Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22772/
> -----------------------------------------------------------
> 
> (Updated June 20, 2014, 9:15 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-6637
>     https://issues.apache.org/jira/browse/HIVE-6637
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-6637: UDF in_file() doesn't take CHAR or VARCHAR as input
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInFile.java ea52537d0b85191f0b633a29aa3f7ddb556c288d

>   ql/src/test/queries/clientpositive/udf_in_file.q 9d9efe8e23d6e73429ee5cd2c8470359ba2b3498

>   ql/src/test/results/clientpositive/udf_in_file.q.out b63143760d80f3f6a8ba0a23c0d87e8bb86fce66

> 
> Diff: https://reviews.apache.org/r/22772/diff/
> 
> 
> Testing
> -------
> 
> Tested with qtest.
> 
> 
> Thanks,
> 
> Ashish Singh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message