hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szehon Ho" <sze...@cloudera.com>
Subject Re: Review Request 22770: Allow partial partition spec in analyze command
Date Thu, 19 Jun 2014 03:51:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22770/#review46179
-----------------------------------------------------------


Hi Ashutosh, it looks good , had some minor questions on this patch.


ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsTask.java
<https://reviews.apache.org/r/22770/#comment81446>

    Looks like no longer used.



ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsTask.java
<https://reviews.apache.org/r/22770/#comment81453>

    We can remove 'totalRows' variable as well.



ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsTask.java
<https://reviews.apache.org/r/22770/#comment81445>

    Do we need to cleanup the fetch operator at some point?



ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java
<https://reviews.apache.org/r/22770/#comment81451>

    Sorry if I misunderstand this, but cant we still set a partial partition spec, for explain?



ql/src/java/org/apache/hadoop/hive/ql/plan/ColumnStatsDesc.java
<https://reviews.apache.org/r/22770/#comment81452>

    Same question, cant we still display partial partition spec?


- Szehon Ho


On June 19, 2014, 2:35 a.m., Ashutosh Chauhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22770/
> -----------------------------------------------------------
> 
> (Updated June 19, 2014, 2:35 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-7255
>     https://issues.apache.org/jira/browse/HIVE-7255
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> So that stats collection can happen for multiple partitions through one statement.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 8ae1c73 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsTask.java 47a6871 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 1270520

>   ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java a4ba4bd 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java b75f78c 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ColumnStatsDesc.java 86e6877 
>   ql/src/test/queries/clientnegative/columnstats_partlvl_dp.q b4887c4 
>   ql/src/test/queries/clientnegative/columnstats_partlvl_incorrect_num_keys.q 2f8e927

>   ql/src/test/queries/clientpositive/columnstats_partlvl_dp.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/columnstats_partlvl_incorrect_num_keys.q PRE-CREATION

>   ql/src/test/results/clientnegative/columnstats_partlvl_invalid_values.q.out d48d8cb

>   ql/src/test/results/clientpositive/columnstats_partlvl.q.out a4c4677 
>   ql/src/test/results/clientpositive/columnstats_partlvl_dp.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/columnstats_partlvl_incorrect_num_keys.q.out PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/22770/diff/
> 
> 
> Testing
> -------
> 
> Moved -ve tests to +ve.
> 
> 
> Thanks,
> 
> Ashutosh Chauhan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message