hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuefu Zhang" <xzh...@cloudera.com>
Subject Re: Review Request 22612: HIVE-7234: Handle nulls from decimal columns elegantly
Date Wed, 18 Jun 2014 23:16:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22612/#review46141
-----------------------------------------------------------



data/files/decimal_9_0.txt
<https://reviews.apache.org/r/22612/#comment81372>

    Combine the two data files.



itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestDecimal.java
<https://reviews.apache.org/r/22612/#comment81371>

    I think the .q file test already covers the test, and this seems complicated and added
no additional value. It might be better to remove this file.



ql/src/test/queries/clientpositive/decimal_10_0.q
<https://reviews.apache.org/r/22612/#comment81370>

    Could we combine the two rows into one data file? In that way, we only need to run one
select query.


- Xuefu Zhang


On June 18, 2014, 9:06 p.m., Ashish Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22612/
> -----------------------------------------------------------
> 
> (Updated June 18, 2014, 9:06 p.m.)
> 
> 
> Review request for hive, Szehon Ho and Xuefu Zhang.
> 
> 
> Bugs: HIVE-7234
>     https://issues.apache.org/jira/browse/HIVE-7234
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-7234: Handle nulls from decimal columns elegantly
> 
> 
> Diffs
> -----
> 
>   data/files/decimal_10_0.txt PRE-CREATION 
>   data/files/decimal_9_0.txt PRE-CREATION 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestDecimal.java PRE-CREATION

>   ql/src/test/queries/clientpositive/decimal_10_0.q PRE-CREATION 
>   ql/src/test/results/clientpositive/decimal_10_0.q.out PRE-CREATION 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyHiveDecimal.java 78cc3819c61f5a1bcb0cdd3425a0105416c26861

>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java 5a4623729ec955bbe8fcf662503b42ff8735eaad

> 
> Diff: https://reviews.apache.org/r/22612/diff/
> 
> 
> Testing
> -------
> 
> Added unit tests to test the scenario.
> 
> 
> Thanks,
> 
> Ashish Singh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message