hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hari Sankar Sivarama Subramaniyan" <hsubramani...@hortonworks.com>
Subject Re: Review Request 22478: HIVE-7188 sum(if()) returns wrong results with vectorization
Date Thu, 12 Jun 2014 01:43:45 GMT


> On June 11, 2014, 11:25 p.m., Jitendra Pandey wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/ColAndCol.java, line
118
> > <https://reviews.apache.org/r/22478/diff/1/?file=607639#file607639line118>
> >
> >     Please confirm hive semantics that
> >     NULL AND FALSE is FALSE and not NULL.

Looked at GenericUDFOPAnd. evaluate(), it will return FALSE if either one of the arguments
is FALSE. So this is consistent with non-vectorized behavior.


- Hari Sankar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22478/#review45438
-----------------------------------------------------------


On June 11, 2014, 9:23 p.m., Hari Sankar Sivarama Subramaniyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22478/
> -----------------------------------------------------------
> 
> (Updated June 11, 2014, 9:23 p.m.)
> 
> 
> Review request for hive, Gopal V and Jitendra Pandey.
> 
> 
> Bugs: HIVE-7188
>     https://issues.apache.org/jira/browse/HIVE-7188
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> ColAndCol.evaluate() is incorrectly implemented. Needed to rewrite the evaluate(). Also
added junit tests.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/ColAndCol.java cb2a952

>   ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorLogicalExpressions.java
3df7c14 
> 
> Diff: https://reviews.apache.org/r/22478/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hari Sankar Sivarama Subramaniyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message