Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E728A1087E for ; Fri, 23 May 2014 05:43:45 +0000 (UTC) Received: (qmail 90273 invoked by uid 500); 23 May 2014 05:43:45 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 90208 invoked by uid 500); 23 May 2014 05:43:45 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 90197 invoked by uid 99); 23 May 2014 05:43:45 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 May 2014 05:43:45 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B7D131D95DB; Fri, 23 May 2014 05:43:37 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3674003546012473362==" MIME-Version: 1.0 Subject: Re: Review Request 21846: Check for filesystem.rename return types From: "Ashish Singh" To: "Szehon Ho" Cc: "Swarnim Kulkarni" , "Ashish Singh" , "hive" Date: Fri, 23 May 2014 05:43:37 -0000 Message-ID: <20140523054337.29379.49865@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ashish Singh" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/21846/ X-Sender: "Ashish Singh" References: <20140523044206.29379.24754@reviews.apache.org> In-Reply-To: <20140523044206.29379.24754@reviews.apache.org> Reply-To: "Ashish Singh" X-ReviewRequest-Repository: hive-git --===============3674003546012473362== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21846/ ----------------------------------------------------------- (Updated May 23, 2014, 5:43 a.m.) Review request for hive and Szehon Ho. Changes ------- Add checks for filesystem.rename return value Summary (updated) ----------------- Check for filesystem.rename return types Repository: hive-git Description ------- HIVE-7117: Partitions not inheriting table permissions after alter rename partition Diffs (updated) ----- common/src/java/org/apache/hadoop/hive/common/FileUtils.java ee61350ab1d32db96a234f6444836f76e23f3251 itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestFolderPermissions.java 4f566d2a2999eecea7018836505208ae80662e97 metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 221b01043b3520211643847c00b17b328ad2b9c0 metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java c1790b427e7fa64780fdf0a580f28135d6a4ff8d Diff: https://reviews.apache.org/r/21846/diff/ Testing ------- Tested with itests. Thanks, Ashish Singh --===============3674003546012473362==--