Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2CB9311D8B for ; Thu, 22 May 2014 22:43:42 +0000 (UTC) Received: (qmail 83208 invoked by uid 500); 22 May 2014 22:43:41 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 83143 invoked by uid 500); 22 May 2014 22:43:41 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 83134 invoked by uid 99); 22 May 2014 22:43:41 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 May 2014 22:43:41 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1A1BE1D9509; Thu, 22 May 2014 22:43:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6761011193236150536==" MIME-Version: 1.0 Subject: Review Request 21831: Make the behavior of CompositeKeyHBaseFactory consistent From: "Swarnim Kulkarni" To: "Swarnim Kulkarni" , "hive" Date: Thu, 22 May 2014 22:43:34 -0000 Message-ID: <20140522224334.29379.96985@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Swarnim Kulkarni" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/21831/ X-Sender: "Swarnim Kulkarni" Reply-To: "Swarnim Kulkarni" X-ReviewRequest-Repository: hive-git --===============6761011193236150536== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21831/ ----------------------------------------------------------- Review request for hive. Bugs: HIVE-7048 https://issues.apache.org/jira/browse/HIVE-7048 Repository: hive-git Description ------- HIVE-6411 introduced a more generic way to provide composite key implementations via custom factory implementations. However it seems like the CompositeHBaseKeyFactory implementation uses a FamilyFilter for row key scans which doesn't seem appropriate. This should be investigated further and if possible replaced with a RowRangeScanFilter. Diffs ----- hbase-handler/src/java/org/apache/hadoop/hive/hbase/CompositeHBaseKeyFactory.java 53fa995 hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseKeyDecomposedPredicate.java PRE-CREATION hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDeParameters.java 07db3af hbase-handler/src/test/org/apache/hadoop/hive/hbase/TestHBaseKeyFactory3.java PRE-CREATION hbase-handler/src/test/queries/positive/hbase_custom_key3.q PRE-CREATION hbase-handler/src/test/results/positive/hbase_custom_key3.q.out PRE-CREATION Diff: https://reviews.apache.org/r/21831/diff/ Testing ------- Tests included with the patch. Thanks, Swarnim Kulkarni --===============6761011193236150536==--