Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 144AC11623 for ; Sat, 17 May 2014 01:12:23 +0000 (UTC) Received: (qmail 22020 invoked by uid 500); 17 May 2014 00:12:07 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 18365 invoked by uid 500); 17 May 2014 00:12:01 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 16683 invoked by uid 99); 17 May 2014 00:06:23 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 17 May 2014 00:06:23 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 551651D7C46; Sat, 17 May 2014 00:06:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4121456572378836101==" MIME-Version: 1.0 Subject: Re: Review Request 21589: HIVE-7080 In PTest framework, Add logs URL to the JIRA comment From: "Szehon Ho" To: "Brock Noland" Cc: "Szehon Ho" , "hive" , "Ashutosh Chauhan" Date: Sat, 17 May 2014 00:06:16 -0000 Message-ID: <20140517000616.1685.83952@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Szehon Ho" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/21589/ X-Sender: "Szehon Ho" References: <20140516232804.1686.48317@reviews.apache.org> In-Reply-To: <20140516232804.1686.48317@reviews.apache.org> Reply-To: "Szehon Ho" X-ReviewRequest-Repository: hive-git --===============4121456572378836101== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On May 16, 2014, 11:28 p.m., Ashutosh Chauhan wrote: > > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/JIRAService.java, line 269 > > > > > > instead of hard-coding url, is it possible to pass this on? Thanks Ashutosh for the review. Sorry for the confusion, the logsURL is taken from a properties file as in the rest of the code. This code in particular is apparently for testing , and not used in production. When it runs it will use these arguments to try to post to a random JIRA. That is what I used to try to verify the functionality. - Szehon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21589/#review43287 ----------------------------------------------------------- On May 16, 2014, 10:57 p.m., Szehon Ho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21589/ > ----------------------------------------------------------- > > (Updated May 16, 2014, 10:57 p.m.) > > > Review request for hive and Brock Noland. > > > Bugs: HIVE-7080 > https://issues.apache.org/jira/browse/HIVE-7080 > > > Repository: hive-git > > > Description > ------- > > Adding a 'test logs' section to the HiveQA's JIRA comment. This is done by yet another build-configuration property "logsURL". > > > Diffs > ----- > > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/JIRAService.java a17295a > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestConfiguration.java 5c552e7 > > Diff: https://reviews.apache.org/r/21589/diff/ > > > Testing > ------- > > Ran the JIRAService as JavaApplication to manually test it. > > > Thanks, > > Szehon Ho > > --===============4121456572378836101==--