Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4463C114C2 for ; Sun, 11 May 2014 04:14:18 +0000 (UTC) Received: (qmail 14165 invoked by uid 500); 10 May 2014 22:23:52 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 14054 invoked by uid 500); 10 May 2014 22:23:52 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 13725 invoked by uid 99); 10 May 2014 22:23:52 -0000 Received: from Unknown (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 May 2014 22:23:52 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 163C71D77BF; Thu, 8 May 2014 00:14:11 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3800947355116905430==" MIME-Version: 1.0 Subject: Re: Review Request 21095: HIVE-7015 Failing to inherit group/permission should not fail the operation From: "Szehon Ho" To: "Brock Noland" Cc: "Szehon Ho" , "hive" Date: Thu, 08 May 2014 00:14:11 -0000 Message-ID: <20140508001411.28778.99718@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Szehon Ho" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/21095/ X-Sender: "Szehon Ho" References: <20140507013747.28779.35229@reviews.apache.org> In-Reply-To: <20140507013747.28779.35229@reviews.apache.org> Reply-To: "Szehon Ho" X-ReviewRequest-Repository: hive-git --===============3800947355116905430== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21095/ ----------------------------------------------------------- (Updated May 8, 2014, 12:14 a.m.) Review request for hive and Brock Noland. Bugs: HIVE-7015 https://issues.apache.org/jira/browse/HIVE-7015 Repository: hive-git Description ------- There was some reported permission errors hit in Fs.setOwner during table creation, when the inherit permission flag was on. I realized that HDFS follows the BSD rule and anyway sets new directory to be the same group as the parent, so actually no need to call 'setOwner' for changing the group during mkdirs. Minor cleanups elsewhere. Changed the other call in mkdirs (Fs.setPermission) to use the shell, so it doesnt throw an error (although I don't see why it should, as folder should be owned by the current user whether its impersonated user or hive). Also changing other places as well to not throw error on failure, although again they shouldn't have failed as these were already using the shell. Diffs ----- common/src/java/org/apache/hadoop/hive/common/FileUtils.java 23a4b8e ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java d8ad873 Diff: https://reviews.apache.org/r/21095/diff/ Testing ------- Ran TestFolderPermissions. Thanks, Szehon Ho --===============3800947355116905430==--