Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C6BF211568 for ; Sat, 3 May 2014 03:44:29 +0000 (UTC) Received: (qmail 65456 invoked by uid 500); 3 May 2014 03:44:28 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 65402 invoked by uid 500); 3 May 2014 03:44:27 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 65392 invoked by uid 99); 3 May 2014 03:44:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 03 May 2014 03:44:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F383F1D74CF; Sat, 3 May 2014 03:44:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6551433732139081057==" MIME-Version: 1.0 Subject: Re: Review Request 20826: HIVE-5823: Support for DECIMAL primitive type in AvroSerDe From: "Xuefu Zhang" To: "Xuefu Zhang" , "hive" , "Skye Wanderman-Milne" Date: Sat, 03 May 2014 03:44:20 -0000 Message-ID: <20140503034420.27445.41021@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Xuefu Zhang" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/20826/ X-Sender: "Xuefu Zhang" References: <20140429171801.3313.33383@reviews.apache.org> In-Reply-To: <20140429171801.3313.33383@reviews.apache.org> Reply-To: "Xuefu Zhang" X-ReviewRequest-Repository: hive-git --===============6551433732139081057== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20826/ ----------------------------------------------------------- (Updated May 3, 2014, 3:44 a.m.) Review request for hive. Bugs: HIVE-5823 https://issues.apache.org/jira/browse/HIVE-5823 Repository: hive-git Description ------- Support decimal type in Avro storage. The implemenation is based on specifications detailed in AVRO-1402. Diffs (updated) ----- data/files/dec.txt PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java ecce21e ql/src/java/org/apache/hadoop/hive/ql/io/avro/AvroGenericRecordReader.java 52a22e5 ql/src/test/queries/clientpositive/avro_decimal.q PRE-CREATION ql/src/test/queries/clientpositive/avro_schema_literal.q d77f310 ql/src/test/results/clientpositive/avro_decimal.q.out PRE-CREATION ql/src/test/results/clientpositive/avro_schema_literal.q.out ca945d5 serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java a28861f serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroGenericRecordWritable.java 8beffd7 serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java 92799ed serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerdeUtils.java 9d58d13 serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerializer.java b2c58c7 serde/src/java/org/apache/hadoop/hive/serde2/avro/SchemaToTypeInfo.java 251f04f serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroSerializer.java b3559ea serde/src/test/org/apache/hadoop/hive/serde2/avro/TestGenericAvroRecordWritable.java a0e5018 serde/src/test/org/apache/hadoop/hive/serde2/avro/Utils.java d5730fa Diff: https://reviews.apache.org/r/20826/diff/ Testing ------- Unit tests are added. Test suite passed. Thanks, Xuefu Zhang --===============6551433732139081057==--