hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thejas M Nair (JIRA)" <>
Subject [jira] [Commented] (HIVE-6923) Use slf4j For Logging Everywhere
Date Mon, 26 May 2014 12:05:01 GMT


Thejas M Nair commented on HIVE-6923:

bq. importantly most of other components in hadoop ecosystem use commons-logging and its important
that we are aligned with hadoop

Hadoop community seems to have formed a consensus around switching to slf4j -

The reasons cited there to use slf4j over commons-logging seems convincing enough -
The best initial thing about SL4FJ is how it only expands its arguments
string values if needed

      LOG.debug("Initialized, principal [{}] from keytab [{}]", principal,

not logging at debug? No need to test first. That alone saves code and
improves readability.


> Use slf4j For Logging Everywhere
> --------------------------------
>                 Key: HIVE-6923
>                 URL:
>             Project: Hive
>          Issue Type: Improvement
>          Components: HiveServer2
>            Reporter: Nick White
>            Assignee: Nick White
>             Fix For: 0.14.0
>         Attachments: HIVE-6923.patch
> Hive uses a mixture of slf4j (backed by log4j) and commons-logging. I've attached a patch
to tidy this up, by just using slf4j for all loggers. This means that applications using the
JDBC driver can make Hive log through their own slf4j implementation consistently.

This message was sent by Atlassian JIRA

View raw message