hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harish Butani" <rhbut...@gmail.com>
Subject Re: Review Request 21970: HIVE-7062: Support Streaming mode in Windowing
Date Thu, 29 May 2014 16:24:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21970/
-----------------------------------------------------------

(Updated May 29, 2014, 4:24 p.m.)


Review request for hive and Ashutosh Chauhan.


Changes
-------

addressed Ashutosh'c comments.
added check if Window Size is less than 'hive.join.cache.size' setting


Bugs: HIVE-7062
    https://issues.apache.org/jira/browse/HIVE-7062


Repository: hive-git


Description
-------

1. Have the Windowing Table Function support streaming mode.
2. Have special handling for Ranking UDAFs.
3. Have special handling for Sum/Avg for fixed size Wdws.


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/PTFOperator.java d3800c2 
  ql/src/java/org/apache/hadoop/hive/ql/exec/PTFPartition.java b5adb11 
  ql/src/java/org/apache/hadoop/hive/ql/exec/PTFRollingPartition.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFAverage.java 814ae37 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCumeDist.java 18c8c8d 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFDenseRank.java c1d43d8 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFEvaluator.java 5668a3b 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFPercentRank.java aab1922 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFRank.java 5c8f1e0 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFStreamingEnhancer.java PRE-CREATION

  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java 8508ffb 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/ISupportStreamingModeForWindowing.java
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/NoopStreaming.java d50a542 
  ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/NoopWithMapStreaming.java be1f9ab 
  ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/TableFunctionEvaluator.java 8a1e085 
  ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/WindowingTableFunction.java cdb5624 
  ql/src/test/org/apache/hadoop/hive/ql/udaf/TestStreamingAvg.java PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/udaf/TestStreamingSum.java PRE-CREATION 
  ql/src/test/results/clientpositive/ptf.q.out eb4997d 
  ql/src/test/results/clientpositive/windowing.q.out 7e23497 
  ql/src/test/results/clientpositive/windowing_windowspec.q.out 6ea068c 

Diff: https://reviews.apache.org/r/21970/diff/


Testing
-------

run existing windowing and ptf tests
Add unit tests for StreamingSum and StreamingAvg evaluators.


Thanks,

Harish Butani


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message