hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szehon Ho" <sze...@cloudera.com>
Subject Re: Review Request 21922: Handover more details on exception in hiveserver2
Date Wed, 28 May 2014 18:58:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21922/#review44140
-----------------------------------------------------------


I have some comments below.


service/src/java/org/apache/hive/service/cli/HiveSQLException.java
<https://reviews.apache.org/r/21922/#comment78467>

    Duplicate null check



service/src/java/org/apache/hive/service/cli/HiveSQLException.java
<https://reviews.apache.org/r/21922/#comment78470>

    Can we consider abstracting this kind of logic into an inner class, so enroll and toStackTrace
become cleaner?
    
    Like ExceptionMetadata(ex, max);
         ExceptionMetadata(stringrep)
    
         String toString()
         String getClass
         String getMessage
         ..etc
      



service/src/java/org/apache/hive/service/cli/HiveSQLException.java
<https://reviews.apache.org/r/21922/#comment78466>

    Can we give more precise message?



shims/0.20S/src/main/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java
<https://reviews.apache.org/r/21922/#comment78465>

    Is this part of this JIRA?  If so, the description should probably reflect it.  If not,
we should take it out , as the jira is about exception reporting


- Szehon Ho


On May 27, 2014, 7:05 a.m., Navis Ryu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21922/
> -----------------------------------------------------------
> 
> (Updated May 27, 2014, 7:05 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-7127
>     https://issues.apache.org/jira/browse/HIVE-7127
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> NO_PRECOMMIT_TEST
> 
> Currently, JDBC hands over exception message and error codes. But it's not helpful for
debugging.
> {noformat}
> org.apache.hive.service.cli.HiveSQLException: Error while compiling statement: FAILED:
ParseException line 1:0 cannot recognize input near 'createa' 'asd' '<EOF>'
> 	at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:121)
> 	at org.apache.hive.jdbc.Utils.verifySuccessWithInfo(Utils.java:109)
> 	at org.apache.hive.jdbc.HiveStatement.execute(HiveStatement.java:231)
> 	at org.apache.hive.beeline.Commands.execute(Commands.java:736)
> 	at org.apache.hive.beeline.Commands.sql(Commands.java:657)
> 	at org.apache.hive.beeline.BeeLine.dispatch(BeeLine.java:889)
> 	at org.apache.hive.beeline.BeeLine.begin(BeeLine.java:744)
> 	at org.apache.hive.beeline.BeeLine.mainWithInputRedirection(BeeLine.java:459)
> 	at org.apache.hive.beeline.BeeLine.main(BeeLine.java:442)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:606)
> 	at org.apache.hadoop.util.RunJar.main(RunJar.java:160)
> {noformat}
> 
> With this patch, JDBC client can get more details on hiveserver2. 
> 
> {noformat}
> Caused by: org.apache.hive.service.cli.HiveSQLException: Error while compiling statement:
FAILED: ParseException line 1:0 cannot recognize input near 'createa' 'asd' '<EOF>'
> 	at org.apache.hive.service.cli.operation.SQLOperation.prepare(Unknown Source)
> 	at org.apache.hive.service.cli.operation.SQLOperation.run(Unknown Source)
> 	at org.apache.hive.service.cli.session.HiveSessionImpl.executeStatementInternal(Unknown
Source)
> 	at org.apache.hive.service.cli.session.HiveSessionImpl.executeStatementAsync(Unknown
Source)
> 	at org.apache.hive.service.cli.CLIService.executeStatementAsync(Unknown Source)
> 	at org.apache.hive.service.cli.thrift.ThriftCLIService.ExecuteStatement(Unknown Source)
> 	at org.apache.hive.service.cli.thrift.TCLIService$Processor$ExecuteStatement.getResult(Unknown
Source)
> 	at org.apache.hive.service.cli.thrift.TCLIService$Processor$ExecuteStatement.getResult(Unknown
Source)
> 	at org.apache.thrift.ProcessFunction.process(Unknown Source)
> 	at org.apache.thrift.TBaseProcessor.process(Unknown Source)
> 	at org.apache.hive.service.auth.TSetIpAddressProcessor.process(Unknown Source)
> 	at org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(Unknown Source)
> 	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
> 	at java.lang.Thread.run(Unknown Source)
> {noformat}
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java dcdd6f2 
>   beeline/src/main/resources/BeeLine.properties 697c29a 
>   jdbc/src/java/org/apache/hive/jdbc/Utils.java 87fec11 
>   service/src/java/org/apache/hive/service/cli/HiveSQLException.java 8c9496e 
>   service/src/test/org/apache/hive/service/cli/TestHiveSQLException.java PRE-CREATION

>   shims/0.20S/src/main/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java e6493eb

> 
> Diff: https://reviews.apache.org/r/21922/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Navis Ryu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message