hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Navis Ryu" <navis....@nexr.com>
Subject Re: Review Request 21841: Hive should support adding multiple resources at once
Date Mon, 26 May 2014 07:24:31 GMT


> On May 23, 2014, 3:06 a.m., Szehon Ho wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/processors/AddResourceProcessor.java, line
57
> > <https://reviews.apache.org/r/21841/diff/1/?file=589213#file589213line57>
> >
> >     Why do we need to make a copy?

Just wanted to exclude first token from input. No need to copy but it looks cleaner.


> On May 23, 2014, 3:06 a.m., Szehon Ho wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/processors/DeleteResourceProcessor.java, line
57
> > <https://reviews.apache.org/r/21841/diff/1/?file=589214#file589214line57>
> >
> >     Why do we need to make a copy?

Same as above.


> On May 23, 2014, 3:06 a.m., Szehon Ho wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java, line 669
> > <https://reviews.apache.org/r/21841/diff/1/?file=589215#file589215line669>
> >
> >     Looks awkward to declare it only here, don't need to in my opinion as its a
RuntimeException.

Yes, right. Wanted to clarify that it can throw exceptions. Should we change this to HiveException?


- Navis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21841/#review43807
-----------------------------------------------------------


On May 23, 2014, 2:14 a.m., Navis Ryu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21841/
> -----------------------------------------------------------
> 
> (Updated May 23, 2014, 2:14 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-3907
>     https://issues.apache.org/jira/browse/HIVE-3907
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Currently hive adds resources in one by one manner. And for JAR resources, one classloader
is created for each jar file, which seemed not good idea.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 49eb83f 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java f3f3619 
>   ql/src/java/org/apache/hadoop/hive/ql/processors/AddResourceProcessor.java 5ed1e6c

>   ql/src/java/org/apache/hadoop/hive/ql/processors/DeleteResourceProcessor.java 83fadeb

>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java dab8610 
>   ql/src/test/org/apache/hadoop/hive/ql/session/TestSessionState.java 7df7ecc 
> 
> Diff: https://reviews.apache.org/r/21841/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Navis Ryu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message