hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Navis Ryu" <navis....@nexr.com>
Subject Re: Review Request 16034: Add explain authorize for checking privileges
Date Sat, 24 May 2014 08:45:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16034/
-----------------------------------------------------------

(Updated May 24, 2014, 8:45 a.m.)


Review request for hive.


Changes
-------

Addressed comments


Bugs: HIVE-5961
    https://issues.apache.org/jira/browse/HIVE-5961


Repository: hive-git


Description
-------

For easy checking of need privileges for a query, 
{noformat}
explain authorize select * from src join srcpart
INPUTS: 
  default@srcpart
  default@srcpart@ds=2008-04-08/hr=11
  default@srcpart@ds=2008-04-08/hr=12
  default@srcpart@ds=2008-04-09/hr=11
  default@srcpart@ds=2008-04-09/hr=12
  default@src
OUTPUTS: 
  file:/home/navis/apache/oss-hive/itests/qtest/target/tmp/localscratchdir/hive_2013-12-04_21-57-53_748_5323811717799107868-1/-mr-10000
CURRENT_USER: 
  hive_test_user
OPERATION: 
  QUERY
AUTHORIZATION_FAILURES: 
  No privilege 'Select' found for inputs { database:default, table:srcpart, columnName:key}
  No privilege 'Select' found for inputs { database:default, table:src, columnName:key}
  No privilege 'Select' found for inputs { database:default, table:src, columnName:key}
{noformat}

Hopefully good for debugging of authorization, which is in progress on HIVE-5837.


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/Driver.java d57dabb 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java 35f4fa9 
  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java db9fa74 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ExplainSemanticAnalyzer.java 26863f1 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 38e8e25 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g af3ecd0 
  ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 5406412 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java b6f3748 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ExplainWork.java d7140ca 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/AuthorizationFactory.java PRE-CREATION

  ql/src/test/queries/clientpositive/authorization_explain.q PRE-CREATION 
  ql/src/test/results/clientpositive/authorization_explain.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/16034/diff/


Testing
-------


Thanks,

Navis Ryu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message