hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szehon Ho" <sze...@cloudera.com>
Subject Re: Review Request 21674: HIVE-7092 Insert overwrite should not delete the original directory
Date Tue, 20 May 2014 20:57:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21674/
-----------------------------------------------------------

(Updated May 20, 2014, 8:57 p.m.)


Review request for hive, Brock Noland and Xuefu Zhang.


Bugs: HIVE-7092
    https://issues.apache.org/jira/browse/HIVE-7092


Repository: hive-git


Description
-------

The implementation of "insert overwrite" table or partition deletes the entire directory of
the table/partition recursively using the HDFS shell (-rmr) and then re-creates it.  This
is for convenience, and also so the data moves first to trash.

Adding util methods to move the contents of a directory to the trash, but keep the directory
itself.


Diffs
-----

  common/src/java/org/apache/hadoop/hive/common/FileUtils.java b15928c 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestFolderPermissions.java
a3ea682 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 51a891c 

Diff: https://reviews.apache.org/r/21674/diff/


Testing
-------

Added a unit test in TestFolderPermissions.

Will manually test on HDFS.


Thanks,

Szehon Ho


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message