hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "justin coffey" <j.cof...@criteo.com>
Subject Review Request 21430: HIVE-6994 - parquet-hive createArray strips null elements
Date Wed, 14 May 2014 09:16:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21430/
-----------------------------------------------------------

Review request for hive.


Repository: hive-git


Description
-------

The createArray method in ParquetHiveSerDe strips null values from resultant ArrayWritables.

This patch:
- removes an incorrect if null check in createArray
- simplifies ParquetHiveSerDe
- total refactor of TestParquetHiveSerDe for better test coverage and easier regression testing


Diffs
-----

  data/files/parquet_create.txt ccd48ee 
  ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ParquetHiveSerDe.java b689336 
  ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestParquetSerDe.java 3b56fc7 
  ql/src/test/org/apache/hadoop/hive/ql/io/parquet/serde/TestParquetHiveSerDe.java PRE-CREATION

  ql/src/test/queries/clientpositive/parquet_create.q 0b976bd 
  ql/src/test/results/clientpositive/parquet_create.q.out 3220be5 

Diff: https://reviews.apache.org/r/21430/diff/


Testing
-------


Thanks,

justin coffey


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message