hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thejas Nair" <the...@hortonworks.com>
Subject Re: Review Request 21289: HIVE-7033 : grant statements should check if the role exists
Date Mon, 12 May 2014 20:25:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21289/
-----------------------------------------------------------

(Updated May 12, 2014, 8:25 p.m.)


Review request for hive and Ashutosh Chauhan.


Changes
-------

Fix possibility of TOCTOU issue.


Bugs: HIVE-7033
    https://issues.apache.org/jira/browse/HIVE-7033


Repository: hive-git


Description
-------

The following grant statement that grants to a role that does not exist succeeds, but it should
result in an error.

> grant all on t1 to role nosuchrole;

Patch also fixes the handling of role names in some cases to be case insensitive.


Diffs (updated)
-----

  metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 4b4f4f2 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrincipal.java 62b8994

  ql/src/test/queries/clientnegative/authorization_role_grant_nosuchrole.q PRE-CREATION 
  ql/src/test/queries/clientnegative/authorization_table_grant_nosuchrole.q PRE-CREATION 
  ql/src/test/queries/clientpositive/authorization_1_sql_std.q 79ae17a 
  ql/src/test/queries/clientpositive/authorization_role_grant1.q f89d0dc 
  ql/src/test/queries/clientpositive/authorization_role_grant2.q 984d7ed 
  ql/src/test/results/clientnegative/authorization_role_grant_nosuchrole.q.out PRE-CREATION

  ql/src/test/results/clientnegative/authorization_table_grant_nosuchrole.q.out PRE-CREATION

  ql/src/test/results/clientpositive/authorization_1_sql_std.q.out 718ff31 
  ql/src/test/results/clientpositive/authorization_role_grant1.q.out 3c846eb 
  ql/src/test/results/clientpositive/authorization_role_grant2.q.out 1e8f88a 

Diff: https://reviews.apache.org/r/21289/diff/


Testing
-------

New tests included


Thanks,

Thejas Nair


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message