hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thejas Nair" <>
Subject Re: Review Request 21289: HIVE-7033 : grant statements should check if the role exists
Date Fri, 09 May 2014 23:14:28 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 9, 2014, 11:14 p.m.)

Review request for hive and Ashutosh Chauhan.


HIVE-7033.2.patch - updating comment in .q file

Bugs: HIVE-7033

Repository: hive-git


The following grant statement that grants to a role that does not exist succeeds, but it should
result in an error.

> grant all on t1 to role nosuchrole;

Patch also fixes the handling of role names in some cases to be case insensitive.

Diffs (updated)

  metastore/src/java/org/apache/hadoop/hive/metastore/ 4b4f4f2 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/ 62b8994

  ql/src/test/queries/clientnegative/authorization_role_grant_nosuchrole.q PRE-CREATION 
  ql/src/test/queries/clientnegative/authorization_table_grant_nosuchrole.q PRE-CREATION 
  ql/src/test/queries/clientpositive/authorization_1_sql_std.q 79ae17a 
  ql/src/test/queries/clientpositive/authorization_role_grant1.q f89d0dc 
  ql/src/test/queries/clientpositive/authorization_role_grant2.q 984d7ed 
  ql/src/test/results/clientnegative/authorization_role_grant_nosuchrole.q.out PRE-CREATION

  ql/src/test/results/clientnegative/authorization_table_grant_nosuchrole.q.out PRE-CREATION

  ql/src/test/results/clientpositive/authorization_1_sql_std.q.out 718ff31 
  ql/src/test/results/clientpositive/authorization_role_grant1.q.out 3c846eb 
  ql/src/test/results/clientpositive/authorization_role_grant2.q.out 1e8f88a 



New tests included


Thejas Nair

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message