hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuefu Zhang" <xzh...@cloudera.com>
Subject Re: Review Request 19984: Beeline should accept -i option to Initializing a SQL file
Date Wed, 07 May 2014 21:44:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19984/#review42430
-----------------------------------------------------------



beeline/src/java/org/apache/hive/beeline/BeeLine.java
<https://reviews.apache.org/r/19984/#comment76223>

    In previous implementation, executing a script file happens after info(getApplicationTitle()),
but new code will do that befort the call. Does this have any side-effect?



beeline/src/java/org/apache/hive/beeline/BeeLine.java
<https://reviews.apache.org/r/19984/#comment76224>

    Does removing this line has any side-effect?



beeline/src/java/org/apache/hive/beeline/BeeLine.java
<https://reviews.apache.org/r/19984/#comment76225>

    While it's good to simply and clean up the old code, in general I'd like to have separate
JIRA tracking each problem. This is fine. My only concern though, is that the old code seems
trying to overcome some difficulty. I'm not sure the new implementation will cover that.


- Xuefu Zhang


On May 7, 2014, 4:10 a.m., Navis Ryu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19984/
> -----------------------------------------------------------
> 
> (Updated May 7, 2014, 4:10 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-6561
>     https://issues.apache.org/jira/browse/HIVE-6561
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Hive CLI has -i option. From Hive CLI help:
> {code}
> ...
>  -i <filename>                    Initialization SQL file
> ...
> {code}
> 
> However, Beeline has no such option:
> {code}
> xzhang@xzlt:~/apa/hive3$ ./packaging/target/apache-hive-0.14.0-SNAPSHOT-bin/apache-hive-0.14.0-SNAPSHOT-bin/bin/beeline
-u jdbc:hive2:// -i hive.rc
> ...
> Connected to: Apache Hive (version 0.14.0-SNAPSHOT)
> Driver: Hive JDBC (version 0.14.0-SNAPSHOT)
> Transaction isolation: TRANSACTION_REPEATABLE_READ
> -i (No such file or directory)
> Property "url" is required
> Beeline version 0.14.0-SNAPSHOT by Apache Hive
> ...
> {code}
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java 5773109 
>   beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 44cabdf 
>   beeline/src/java/org/apache/hive/beeline/Commands.java 493f963 
>   beeline/src/main/resources/BeeLine.properties 697c29a 
> 
> Diff: https://reviews.apache.org/r/19984/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Navis Ryu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message