Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CC53410B7F for ; Wed, 9 Apr 2014 05:00:30 +0000 (UTC) Received: (qmail 70331 invoked by uid 500); 9 Apr 2014 05:00:27 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 70242 invoked by uid 500); 9 Apr 2014 05:00:21 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 70181 invoked by uid 500); 9 Apr 2014 05:00:18 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 70175 invoked by uid 99); 9 Apr 2014 05:00:18 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Apr 2014 05:00:18 +0000 Date: Wed, 9 Apr 2014 05:00:18 +0000 (UTC) From: "Szehon Ho (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-6853) show create table for hbase tables should exclude LOCATION MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963806#comment-13963806 ] Szehon Ho commented on HIVE-6853: --------------------------------- Thanks , for the most part it LGTM. I guess its not the cleanest, as its breaking the StorageHandler abstraction. Probably cleaner to add some hook to StorageHandler interface, but due to backward compatibility, its probably not worth it for this use-case. +1 (non-binding) > show create table for hbase tables should exclude LOCATION > ----------------------------------------------------------- > > Key: HIVE-6853 > URL: https://issues.apache.org/jira/browse/HIVE-6853 > Project: Hive > Issue Type: Bug > Components: StorageHandler > Affects Versions: 0.10.0 > Reporter: Miklos Christine > Attachments: HIVE-6853-0.patch, HIVE-6853.patch > > > If you create a table on top of hbase in hive and issue a "show create table ", it gives a bad DDL. It should not show LOCATION: > [hive]$ cat /tmp/test_create.sql > CREATE EXTERNAL TABLE nba_twitter.hbase2( > key string COMMENT 'from deserializer', > name string COMMENT 'from deserializer', > pdt string COMMENT 'from deserializer', > service string COMMENT 'from deserializer', > term string COMMENT 'from deserializer', > update1 string COMMENT 'from deserializer') > ROW FORMAT SERDE > 'org.apache.hadoop.hive.hbase.HBaseSerDe' > STORED BY > 'org.apache.hadoop.hive.hbase.HBaseStorageHandler' > WITH SERDEPROPERTIES ( > 'serialization.format'='1', > 'hbase.columns.mapping'=':key,srv:name,srv:pdt,srv:service,srv:term,srv:update') > LOCATION > 'hdfs://nameservice1/user/hive/warehouse/nba_twitter.db/hbase' > TBLPROPERTIES ( > 'hbase.table.name'='NBATwitter', > 'transient_lastDdlTime'='1386172188') > Trying to create a table using the above fails: > [hive]$ hive -f /tmp/test_create.sql > cli "-f /tmp/test_create.sql" > Logging initialized using configuration in jar:file:/opt/cloudera/parcels/CDH-4.4.0-1.cdh4.4.0.p0.39/lib/hive/lib/hive-common-0.10.0-cdh4.4.0.jar!/hive-log4j.properties > FAILED: Error in metadata: MetaException(message:LOCATION may not be specified for HBase.) > FAILED: Execution Error, return code 1 from org.apache.hadoop.hive.ql.exec.DDLTask > However, if I remove the LOCATION, then the DDL is valid. -- This message was sent by Atlassian JIRA (v6.2#6252)