Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Tue, 1 Apr 2014 01:04:10 +0000 (UTC)
From: "Harish Butani (JIRA)" <jira@apache.org>
To: hive-dev@hadoop.apache.org
Message-ID: <JIRA.12704413.1396069242071.40514.1396314250546@arcas>
In-Reply-To: <JIRA.12704413.1396069242071@arcas>
References: <JIRA.12704413.1396069242071@arcas>
Subject: [jira] [Commented] (HIVE-6786) Off by one error in ORC PPD
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HIVE-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955967#comment-13955967 ] 

Harish Butani commented on HIVE-6786:
-------------------------------------

+1 for 0.13

> Off by one error in ORC PPD 
> ----------------------------
>
>                 Key: HIVE-6786
>                 URL: https://issues.apache.org/jira/browse/HIVE-6786
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.13.0
>            Reporter: Gopal V
>            Assignee: Prasanth J
>            Priority: Critical
>             Fix For: 0.13.0
>
>         Attachments: HIVE-6786.1.patch
>
>
> Turning on ORC PPD makes split computation fail for a 10Tb benchmark.
> Narrowed down to the following code fragment
> https://github.com/apache/hive/blob/branch-0.13/ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java#L757
> {code}
>                 includeStripe[i] = (i > stripeStats.size()) ||
>                     isStripeSatisfyPredicate(stripeStats.get(i), sarg,
>                                              filterColumns);
> {code}
> I would guess that should be a >=, but [~prasanth_j], can you comment if that is the right fix?


--
This message was sent by Atlassian JIRA
(v6.2#6252)