Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4089DFF5E for ; Mon, 28 Apr 2014 18:28:50 +0000 (UTC) Received: (qmail 68008 invoked by uid 500); 28 Apr 2014 18:28:47 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 67889 invoked by uid 500); 28 Apr 2014 18:28:47 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 67877 invoked by uid 99); 28 Apr 2014 18:28:46 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Apr 2014 18:28:46 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D68BE1D5496; Mon, 28 Apr 2014 18:28:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5538286993994534111==" MIME-Version: 1.0 Subject: Re: Review Request 20737: HIVE-6031: explain subquery rewrite for where clause predicates From: "Ashutosh Chauhan" To: "Ashutosh Chauhan" Cc: "Harish Butani" , "hive" Date: Mon, 28 Apr 2014 18:28:40 -0000 Message-ID: <20140428182840.30655.70906@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ashutosh Chauhan" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/20737/ X-Sender: "Ashutosh Chauhan" References: <20140425225746.9570.54195@reviews.apache.org> In-Reply-To: <20140425225746.9570.54195@reviews.apache.org> Reply-To: "Ashutosh Chauhan" X-ReviewRequest-Repository: hive-git --===============5538286993994534111== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20737/#review41607 ----------------------------------------------------------- Few comments. Major one is to drop subquery from explain subquery rewrite syntax. ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainSQRewriteTask.java will be good to add a comment here for this replacement. ql/src/java/org/apache/hadoop/hive/ql/parse/ExplainSQRewriteSemanticAnalyzer.java Is this needed ? Looks redundant code. If not, good to put some comments here. ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g I think we should not have explain subquery rewrite .. rather explain rewrite .. because later on we may want to extend this explain functionality beyond just subquery rewrites. ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryDiagnostic.java Doesn't make lot of difference, but QBSQRewrite extends QBSQRewriteNoop seems more natural. ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryDiagnostic.java Also, good to add a note here saying its non-explain path. - Ashutosh Chauhan On April 25, 2014, 10:57 p.m., Harish Butani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20737/ > ----------------------------------------------------------- > > (Updated April 25, 2014, 10:57 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-6031 > https://issues.apache.org/jira/browse/HIVE-6031 > > > Repository: hive-git > > > Description > ------- > > explain subquery rewrite for where clause predicates > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainSQRewriteTask.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/TaskFactory.java 679c6ec > ql/src/java/org/apache/hadoop/hive/ql/parse/ExplainSQRewriteSemanticAnalyzer.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 3e673ca > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 13bbf0a > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 864e692 > ql/src/java/org/apache/hadoop/hive/ql/parse/QB.java a8b436e > ql/src/java/org/apache/hadoop/hive/ql/parse/QBSubQuery.java b7c9e65 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 3b33dc2 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java e7d0359 > ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryDiagnostic.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryUtils.java 07d32ed > ql/src/java/org/apache/hadoop/hive/ql/plan/ExplainSQRewriteWork.java PRE-CREATION > ql/src/test/queries/clientpositive/subquery_exists_explain_rewrite.q PRE-CREATION > ql/src/test/queries/clientpositive/subquery_in_explain_rewrite.q PRE-CREATION > ql/src/test/results/clientpositive/subquery_exists_explain_rewrite.q.out PRE-CREATION > ql/src/test/results/clientpositive/subquery_in_explain_rewrite.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/20737/diff/ > > > Testing > ------- > > new tests added > > > Thanks, > > Harish Butani > > --===============5538286993994534111==--