Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Content-Type: multipart/alternative;
 boundary="===============5304931548298611761=="
MIME-Version: 1.0
Subject: Re: Review Request 20243: HIVE-6891 - Alter rename partition Perm
 inheritance and general partition/table owner inheritance
From: "Brock Noland" <brock@cloudera.com>
To: "Szehon Ho" <szehon@cloudera.com>, "hive" <dev@hive.apache.org>,
 "Brock Noland" <brock@cloudera.com>
Date: Fri, 11 Apr 2014 00:52:37 -0000
Message-ID: <20140411005237.22531.67798@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Brock Noland" <noreply@reviews.apache.org>
References: <20140411004933.22531.60055@reviews.apache.org>
In-Reply-To: <20140411004933.22531.60055@reviews.apache.org>
Reply-To: "Brock Noland" <brock@cloudera.com>

--===============5304931548298611761==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20243/#review40113
-----------------------------------------------------------


I don't think we will be able to set owner since we are not superuer? But we can set and should set group.

- Brock Noland


On April 11, 2014, 12:49 a.m., Szehon Ho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20243/
> -----------------------------------------------------------
> 
> (Updated April 11, 2014, 12:49 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-6891
>     https://issues.apache.org/jira/browse/HIVE-6891
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> This is a follow-up of HIVE-6648.
> 
> Extending the fix to other partition/table operations as well, by refactoring the fixed code in HIVE-6648 into a common FileUtils helper method, and then using it for all table/partition directory creation operation, when "hive.warehouse.subdir.inherit.perms" flag is set.  
> 
> Another part of this change is to add ownership inheritance in this code as well when creating directories.  Ownership was already inherited for data (HIVE-3756), but not at the table/partitioned-table level.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/FileUtils.java ad82f62 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestFolderPermissions.java f1c7b7b 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 8345d70 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c62e085 
>   metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java f731dab 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 2559e0e 
> 
> Diff: https://reviews.apache.org/r/20243/diff/
> 
> 
> Testing
> -------
> 
> Extending the unit test TestFolderPermission to handle all the new cases of directory creation (create table, external table, static partition, dynamic partition, rename partition).
> 
> Unfortunately due to the test using the local file system, I cannot add the ownership inheritance to unit-testing.  I can probably look into using MiniDFS for that, in a follow-up JIRA.
> 
> 
> Thanks,
> 
> Szehon Ho
> 
>


--===============5304931548298611761==--