hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sushanth Sowmyan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-5336) HCatSchema.remove(HCatFieldSchema hcatFieldSchema) should renumber the fieldPositionMap and the fieldPositionMap should not be cached by the end user
Date Sat, 12 Apr 2014 09:10:14 GMT

    [ https://issues.apache.org/jira/browse/HIVE-5336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967450#comment-13967450
] 

Sushanth Sowmyan commented on HIVE-5336:
----------------------------------------

The failed tests are not related to this issue, I can go ahead and commit.

> HCatSchema.remove(HCatFieldSchema hcatFieldSchema) should renumber the  fieldPositionMap
and the fieldPositionMap should not be cached by the end user
> ------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-5336
>                 URL: https://issues.apache.org/jira/browse/HIVE-5336
>             Project: Hive
>          Issue Type: Bug
>          Components: HCatalog
>            Reporter: Hari Sankar Sivarama Subramaniyan
>            Assignee: Hari Sankar Sivarama Subramaniyan
>         Attachments: HIVE-5336.1.patch.txt, HIVE-5336.2.patch.txt, HIVE-5336.3.patch
>
>
> HCatSchema.remove currently does not renumber the fieldPositionMap which can be a problem
when there are interleaving append() and remove() calls.
> 1. We should document that fieldPositionMap should not be cached by the end-user
> 2. We should make sure that the fieldPositionMap gets renumbered after remove() because
HcatSchema.get will otherwise return wrong FieldSchemas.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message