hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Zhitomirsky" <ben...@gmail.com>
Subject Re: Review Request 19923: HIVE-6374: Hive job submitted with non-default name node (fs.default.name) doesn't process locations properly
Date Wed, 30 Apr 2014 11:14:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19923/
-----------------------------------------------------------

(Updated April 30, 2014, 11:14 a.m.)


Review request for hive.


Changes
-------

Updated after sync with latest trunk
Fixed bug wrong casing of table/index/db paths


Repository: hive-git


Description
-------

Create table/index/database and add partition DDL doesn't work properly if all following conditions
are true:
-Metastore service is used
-fs.default.name is specified and it differs from the default one
-Location is not specified or specified as a not fully qualified URI

The root cause of this behavior is that Hive client doesn't pass configuration context to
the metastore services which tries to resolve the paths. The fix is it too resolve the path
in the Hive client if fs.default.name is specified and it differs from the default one (it
is must easier then start passing the context, which would be a major change).


Diffs (updated)
-----

  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestDDLWithRemoteMetastoreSecondNamenode.java
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java ca51e71 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 3ea2163 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java d8ad873 

Diff: https://reviews.apache.org/r/19923/diff/


Testing
-------

Tested in deployed Hadoop cluster. New class with two tests added.


Thanks,

Benjamin Zhitomirsky


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message