hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szehon Ho" <sze...@cloudera.com>
Subject Re: Review Request 20103: HIVE-6843 INSTR for UTF-8 returns incorrect position
Date Sat, 19 Apr 2014 00:06:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20103/
-----------------------------------------------------------

(Updated April 19, 2014, 12:06 a.m.)


Review request for hive.


Changes
-------

Handle the 'surrogate' case.


Repository: hive-git


Description
-------

Seems the original authors wanted to avoid encoding, but this is not possible if you want
to handle Unicode characters.


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtils.java 7f4a807 
  ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFUtils.java d9338a5 

Diff: https://reviews.apache.org/r/20103/diff/


Testing
-------

Adding some unicode test of Cyrillic chars.


Thanks,

Szehon Ho


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message