hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szehon Ho" <>
Subject Re: Review Request 15797: HIVE-5870 - Move TestJDBCDriver2.testNewConnectionConfiguration to TestJDBCWithMiniHS2
Date Fri, 18 Apr 2014 22:08:18 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 18, 2014, 10:08 p.m.)

Review request for hive.



Bugs: HIVE-5870

Repository: hive-git


TestJDBCDriver2.testNewConnectionConfiguration() attempts to start a Hiveserver2 instance
and test connect to it.  This can cause issues as creating HiveServer2 needs correct environment.
 This test should be moved to TestJdbcWithMiniHS2, which uses MiniHS2.  MiniHS2 is for this
purpose, as it sets all the environment properly before starting HiveServer2 instance.

This test now runs the same commands against the MiniHS2.  In the course of refactoring, also
changed TestJdbcWithMiniHS2's MiniHS2 creation from @Before to @BeforeClass (ie, once per
test), as calling init() multiple times on the HiveMetastore causes strange errors from DataNucleus/embedded
Derby.  Also, it is more efficient.

Diffs (updated)

  itests/hive-unit/src/test/java/org/apache/hive/jdbc/ e71ccb9 
  itests/hive-unit/src/test/java/org/apache/hive/jdbc/ 12de644 



Ran affected unit tests.


Szehon Ho

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message