hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuefu Zhang" <xzh...@cloudera.com>
Subject Re: Review Request 20435: HIVE-6916 - Export/import inherit permissions from parent directory
Date Fri, 18 Apr 2014 02:55:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20435/#review40736
-----------------------------------------------------------



itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestFolderPermissions.java
<https://reviews.apache.org/r/20435/#comment73880>

    Minor Nit, could you rename the method to make more explicit?



ql/src/java/org/apache/hadoop/hive/ql/exec/CopyTask.java
<https://reviews.apache.org/r/20435/#comment73879>

    It's interesting to note that we already have FileUtil.copy() somewhere, while you created
a different version in FileUtils.copy(). Couldn't we enhance existing one instead? Or at least,
put those related method close together.


- Xuefu Zhang


On April 17, 2014, 4:58 a.m., Szehon Ho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20435/
> -----------------------------------------------------------
> 
> (Updated April 17, 2014, 4:58 a.m.)
> 
> 
> Review request for hive and Brock Noland.
> 
> 
> Bugs: HIVE-6916
>     https://issues.apache.org/jira/browse/HIVE-6916
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> This fixes the CopyTask (used by export/import) to also do the permission inheritance
semantics, if the flag is on.  Like elsewhere in the code, this is using the HDFS shell because
it allows specification of recursion (whereas I could not find it in the HDFS-API).
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/FileUtils.java b36a016 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestFolderPermissions.java
a635bb0 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/CopyTask.java b429a58 
> 
> Diff: https://reviews.apache.org/r/20435/diff/
> 
> 
> Testing
> -------
> 
> Added a unit test for the same.
> 
> 
> Thanks,
> 
> Szehon Ho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message